Skip to content

fix(release-notes): require token on CI, warn for local development#4598

Merged
brandyscarney merged 9 commits into
mainfrom
FW-7622
Jul 21, 2026
Merged

fix(release-notes): require token on CI, warn for local development#4598
brandyscarney merged 9 commits into
mainfrom
FW-7622

Conversation

@brandyscarney

@brandyscarney brandyscarney commented Jul 20, 2026

Copy link
Copy Markdown
Member

This PR fixes the release notes generation failing on Vercel:

  • Updates the repository path to ionic-team/ionic-framework
  • Improved build output with cleaner logging
  • Adds contributing section for keeping PAT updated

Production Release Notes: https://ionicframework.com/docs/reference/release-notes
Branch Release Notes: https://ionic-docs-git-fw-7622-ionic1.vercel.app/docs/reference/release-notes

@vercel

vercel Bot commented Jul 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ionic-docs Ready Ready Preview, Comment Jul 21, 2026 5:32pm

Request Review

@brandyscarney
brandyscarney marked this pull request as ready for review July 20, 2026 18:50
@brandyscarney
brandyscarney requested a review from a team as a code owner July 20, 2026 18:50
@brandyscarney
brandyscarney requested a review from BenOsodrac July 20, 2026 18:50

@ShaneK ShaneK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea behind these changes but I believe the current implementation of them limits public contribution, which isn't ideal

Comment thread scripts/release-notes.mjs Outdated
Comment thread scripts/release-notes.mjs Outdated
@gnbm
gnbm removed the request for review from BenOsodrac July 20, 2026 21:41

@ShaneK ShaneK left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

Comment thread package.json
Comment thread src/components/page/reference/ReleaseNotes/index.tsx
@brandyscarney brandyscarney changed the title fix(release-notes): properly pull in release notes fix(release-notes): require token on CI, warn for local development Jul 21, 2026
@brandyscarney
brandyscarney merged commit ac062bd into main Jul 21, 2026
4 checks passed
@brandyscarney
brandyscarney deleted the FW-7622 branch July 21, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants