Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
package: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Currently,
@types/nodeis inconsistent across the monorepoWhat is the new behavior?
All seven packages that declare
@types/nodenow use^24.13.3, matching the Node 24.x that CI actually runs. I went to 24 rather than the 22 mentioned on the ticket because every workflow we use pinsnode-version: 24.x, so 24 is the version that we actually use. That also meant pullingangular,angular-server, andmigrateup from^22, since leaving them behind wouldn't be aligned, which was the goal of this pass.This is a devDependency, so there's no user facing changes that need to be documented here.
Does this introduce a breaking change?
Other information
The test for this is CI. If it passes, then we're good