Add late-transformation-stage plugin hooks - #3769
Merged
Merged
Conversation
These hooks were added for device plugins (coming soon) and for plugins that need to look at final data structures before providers modify them (for example, check.config)
Contributor
There was a problem hiding this comment.
Pull request overview
Adds additional late-stage plugin hook points to the topology transformation pipeline, enabling plugins to inspect/adjust near-final topology data (including after device quirks and provider transforms).
Changes:
- Invoke new plugin hooks around the device-quirks stage (
pre_quirks,post_quirks). - Invoke a new plugin hook after provider post-transform processing (
post_provider_transform). - Document the new transformation-stage plugin hooks in developer documentation.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| netsim/augment/main.py | Adds late-stage plugin hook executions around quirks and provider post-transform. |
| docs/dev/plugins.md | Documents the new plugin hook stages and their intended usage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These hooks were added for device plugins (coming soon) and for plugins that need to look at final data structures before providers modify them (for example, check.config)