Implement NX-OS reprovisioning via NX-API - #381
Merged
Conversation
felix-kaestner
force-pushed
the
chore/nxos-reprovision
branch
from
May 28, 2026 08:30
9ac1150 to
48f2d50
Compare
felix-kaestner
marked this pull request as draft
June 4, 2026 09:23
felix-kaestner
force-pushed
the
chore/nxos-reprovision
branch
from
June 19, 2026 12:14
48f2d50 to
72080cf
Compare
felix-kaestner
marked this pull request as ready for review
June 19, 2026 12:15
felix-kaestner
force-pushed
the
chore/nxos-reprovision
branch
from
June 23, 2026 12:24
72080cf to
8547f3b
Compare
felix-kaestner
force-pushed
the
chore/nxos-reprovision
branch
from
July 8, 2026 16:30
8547f3b to
28958c3
Compare
IvoGoman
reviewed
Jul 17, 2026
felix-kaestner
force-pushed
the
chore/nxos-reprovision
branch
2 times, most recently
from
July 17, 2026 14:52
346057f to
533f156
Compare
IvoGoman
approved these changes
Jul 22, 2026
Replace the defunct GNMI-based reprovisioning with NXAPI JSON-RPC calls. The new implementation issues two requests: 1. boot poap enable + copy running-config startup-config (batched with stop-on-error rollback) 2. reload (separate request that tolerates transport errors because the device goes down before responding) Add nxapi.IsTransportError to distinguish network-level errors (EOF, timeout, connection reset) from logical errors (RPCError, HTTPError), enabling callers of disruptive commands to tolerate expected connection drops. Remove the now unused BootPOAP GNMI type. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Move the maintenance annotation deletion to after the switch statement so it is only removed when the action succeeds. This allows the reconciler to retry failed maintenance operations on the next reconciliation instead of requiring the user to re-apply the annotation. Additionally, return a terminal error for unknown maintenance actions since retrying will never succeed. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Add a functional option to nxapi.NewClient that overrides the port in the connection address. This allows tests to point the client at an httptest server on a random port. Reprovision now reuses p.nxapi if already set (e.g. from Connect or injected by a test), falling back to creating a standalone client with port stripping for production. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Replace the positional timeout parameter in NewClient with a WithTimeout option, consistent with WithPort. The default is 0 (no timeout). Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Maintenance operations (reboot, factory reset, reprovision) require an established provider connection. Previously they were called without Connect, which meant Reboot and FactoryReset would use a nil gRPC connection and Reprovision had to create its own NX-API client as a workaround. Wrap device-targeting maintenance actions in the same Connect/Disconnect pattern used by reconcile and reconcileMinimal. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
Now that reconcileMaintenance calls Connect before invoking Reprovision, the fallback client creation is unnecessary. Reprovision can use p.nxapi directly, matching all other provider methods. Signed-off-by: Felix Kästner <felix.kaestner@sap.com>
felix-kaestner
force-pushed
the
chore/nxos-reprovision
branch
from
July 22, 2026 13:42
533f156 to
decbea9
Compare
Merging this branch changes the coverage (1 decrease, 2 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the defunct GNMI-based reprovisioning with NXAPI JSON-RPC calls. The new implementation issues two requests:
Add nxapi.IsTransportError to distinguish network-level errors (EOF, timeout, connection reset) from logical errors (RPCError, HTTPError), enabling callers of disruptive commands to tolerate expected connection drops.
Remove the now unused BootPOAP GNMI type.