-
Notifications
You must be signed in to change notification settings - Fork 1
Let system() and command-pipe children inherit the standard input #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1d317b1
Let system() and command-pipe children inherit the standard input
bertysentry eb3a239
Address review: harden stdin-inheritance guard and test plumbing
bertysentry 2dd51dc
Address review: assert stdin eligibility from the process entry point
bertysentry 786cd0c
Address review: make main's process-entry contract explicit
bertysentry e1b326d
Merge origin/main into 575-spawned-processes-inherit-stdin
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| package io.jawk; | ||
|
|
||
| /*- | ||
| * ╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲ | ||
| * Jawk | ||
| * ჻჻჻჻჻჻ | ||
| * Copyright (C) 2006 - 2026 MetricsHub | ||
| * ჻჻჻჻჻჻ | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU Lesser General Public License as | ||
| * published by the Free Software Foundation, either version 3 of the | ||
| * License, or (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Lesser Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Lesser Public | ||
| * License along with this program. If not, see | ||
| * <http://www.gnu.org/licenses/lgpl-3.0.html>. | ||
| * ╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱╲╱ | ||
| */ | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
|
|
||
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * Verifies that the children of {@code system()} and of a command input pipe | ||
| * ({@code "cmd" | getline}) inherit Jawk's standard input, as POSIX requires, | ||
| * when Jawk reads the standard input of the JVM — and that embedded executions | ||
| * bound to a custom stream keep the child's standard input closed. | ||
| * <p> | ||
| * The inheritance can only be observed across a real process boundary, so the | ||
| * inheriting cases run through | ||
| * {@link AwkTestSupport#runCliInFreshJvm(String, String, String)}, which | ||
| * spawns the CLI in a fresh JVM whose standard input is redirected from a | ||
| * file. | ||
| */ | ||
| public class SpawnedProcessStdinTest { | ||
|
|
||
| @Test | ||
| public void commandInputPipeChildReadsJawkStandardInput() throws Exception { | ||
| String output = AwkTestSupport | ||
| .runCliInFreshJvm( | ||
| "cmd|getline child reads Jawk stdin", | ||
| "BEGIN { \"sort\" | getline line; print \"[\" line \"]\" }", | ||
| "hello\n"); | ||
| assertEquals("[hello]\n", output); | ||
| } | ||
|
|
||
| @Test | ||
| public void systemChildReadsJawkStandardInput() throws Exception { | ||
| String output = AwkTestSupport | ||
| .runCliInFreshJvm( | ||
| "system() child reads Jawk stdin", | ||
| "BEGIN { system(\"sort\") }", | ||
| "zulu\nalpha\n"); | ||
| assertEquals("alpha\nzulu\n", output); | ||
| } | ||
|
|
||
| @Test | ||
| public void embeddedExecutionKeepsChildStandardInputClosed() throws Exception { | ||
| // A custom input stream cannot be lent to another OS process, so the | ||
| // child sees end of input at once and getline returns 0 | ||
| AwkTestSupport | ||
| .cliTest("embedded cmd|getline child gets no standard input") | ||
| .script("BEGIN { n = (\"sort\" | getline line); print n \"[\" line \"]\" }") | ||
| .stdin("never seen by the child\n") | ||
| .expectLines("0[]") | ||
| .runAndAssert(); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an embedder or test calls the public
Cli.mainafterSystem.setIn(customStream), this unconditional flag makessystem()and command-pipe children inherit the process's native descriptor 0 even though Jawk itself reads the replacement stream, so a child can block on or consume unrelated host input. The repository already invokesCli.mainprogrammatically inAwkTest.java, somainis not exclusively an OS launch path. The fresh evidence relative to the earlier finding is this new unconditional assignment; eligibility must only be enabled when the CLI input is actually backed by native stdin.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that no capture or flag can survive a programmatic
Cli.maincall afterSystem.setIn— and there is no supported Java-side check that can tell the launcher-installedSystem.infrom a replacement (the fd0 backing of a stream is not observable without deep reflection intojava.io). So the boundary is now drawn as a documented contract instead:Cli.maincarries process semantics — it is what thejawklaunch of the JVM runs, and its children may inherit the process's standard input, as POSIX requires of awk. Code that replacesSystem.inmust go throughcreate(), the constructors, or theAwkAPI, where spawned children always get a closed standard input. The one programmaticCli.maincall in the test suite (AwkTest.compileTuplesViaCLI) now goes throughcreate()accordingly, so nothing in the repository callsmainprogrammatically anymore.