Skip to content

Fix: Change OKP JWK thumbprint to use crv/kty/x, not RSA's kty/n/x #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anakinj merged 1 commit into from
Aug 13, 2026
Merged

Fix: Change OKP JWK thumbprint to use crv/kty/x, not RSA's kty/n/x #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jwt/eddsa/jwk/okp.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module JWK
class OKP < ::JWT::JWK::KeyBase
KTY = "OKP"
KTYS = [KTY, JWT::EdDSA::JWK::OKP, Ed25519::SigningKey, Ed25519::VerifyKey].freeze
OKP_PUBLIC_KEY_ELEMENTS = %i[kty n x].freeze
OKP_PUBLIC_KEY_ELEMENTS = %i[crv kty x].freeze
OKP_PRIVATE_KEY_ELEMENTS = %i[d].freeze

def initialize(key, params = nil, options = {})
Expand Down
10 changes: 10 additions & 0 deletions spec/jwt/jwk/okp_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,16 @@
end
end

describe "#kid" do
# Test vector from RFC 8037 Appendix A.3 (JWK Thumbprint Canonicalization):
# https://www.rfc-editor.org/rfc/rfc8037#appendix-A.3
let(:key) { { kty: "OKP", crv: "Ed25519", x: "11qYAYKxCrfVS_7TyWQHOg7hcvPapiMlrwIaaPcHURo" } }

it "matches the RFC 7638 JWK thumbprint of the crv/kty/x members" do
expect(instance.kid).to eq("kPrK_qmxVWaYVA9wwBF6Iuo3vVzz7TxHCTwXBygrS4k")
end
end

describe "#export" do
let(:options) { {} }
subject { instance.export(options) }
Expand Down
Loading