Exclude fn-config from owning function's input in fn render - #4673
Merged
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
aravindtga
force-pushed
the
fn-render-exclude-own-fnconfig
branch
2 times, most recently
from
July 30, 2026 15:22
0781cc8 to
8c76035
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns kpt fn render with the documented function contract by ensuring a function’s own configPath resource is not included in resourceList.items for that function (it should only be provided via resourceList.functionConfig), matching the behavior previously implemented for fn eval.
Changes:
- Updated render pipeline execution to exclude a mutator/validator’s own
configPathresource from its input items while keeping it available to other functions. - Added unit tests validating fn-config exclusion behavior (including nested packages and error paths) and updated fn-render e2e expected diffs.
- Updated documentation and API comments to describe the refined
configPathcontract.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/lib/kptops/render_executor.go | Filters out the owning function’s configPath resource from its input items during render execution (mutators/validators). |
| pkg/lib/kptops/render_executor_test.go | Adds unit tests to assert fn-config exclusion, preservation on disk, nested package behavior, and error restoration. |
| e2e/testdata/fn-render/modify-path-annotation/.expected/diff.patch | Updates expected diff to reflect fn-config no longer being mutated as an input item by its owning function. |
| e2e/testdata/fn-render/fnconfig/.expected/diff.patch | Updates expected output/results counts and removes expected fn-config mutations by the owning function. |
| e2e/testdata/fn-render/fnconfig-pkgfn-refers-subdir/.expected/diff.patch | Updates expected output/results counts and removes expected fn-config mutations by the owning function. |
| e2e/testdata/fn-render/fnconfig-in-subdir/.expected/diff.patch | Updates expected output/results counts and removes expected fn-config mutations by the owning function. |
| e2e/testdata/fn-render/fnconfig-ancestorfn-not-mutate-subpkg-config/.expected/diff.patch | Updates expected output/results counts and removes expected fn-config mutations by the owning function. |
| documentation/content/en/book/04-using-functions/_index.md | Documents that a function won’t receive its own configPath resource in input items. |
| api/kptfile/v1/types.go | Updates ConfigPath field comment to match the new contract. |
aravindtga
marked this pull request as ready for review
July 30, 2026 16:16
aravindtga
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
July 30, 2026 16:16
dosubot
Bot
added
size:M
aravindtga
marked this pull request as draft
July 30, 2026 16:33
aravindtga
marked this pull request as ready for review
July 30, 2026 16:33
kushnaidu
approved these changes
Aug 5, 2026
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
fn-render-exclude-own-fnconfig
branch
2 times, most recently
from
August 5, 2026 16:23
55b088a to
c297bee
Compare
|
liamfallon
approved these changes
Aug 7, 2026
Contributor
|
As this is a behavioural change please ask @mozesl-nokia to review this PR. |
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
aravindtga
force-pushed
the
fn-render-exclude-own-fnconfig
branch
from
August 11, 2026 14:35
c297bee to
1b2d8f2
Compare
mozesl-nokia
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
kpt fn renderexecutes a pipeline, function configs specified viaconfigPathwere included inresourceList.itemsfor their owning function. This allowed functions to mutate their own configuration, violating the documented contract thatconfigPathresources should only be accessible viaresourceList.functionConfig.This change excludes a function's own
configPathresource from its input items duringfn render, matching the behavior already implemented forfn evalin PR #4639. The fn-config remains visible to other functions in the pipeline (it is only excluded from its owning function).What changed
runMutators: Before executing each mutator, itsconfigPathresource is removed from the input list usingslices.DeleteFunc. It is added back unmodified after execution so subsequent functions can still see it and the file is not pruned from disk.runValidators: Same exclusion usingslices.Clone+slices.DeleteFuncto create a filtered copy (originalinputstays intact since validators don't modify it).Related Issue(s)
fn renderportion)Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to analyse the issue, validate the fix, generate unit/E2E tests and draft PR message.