Skip to content

fixed render displaying sub packages without any pipelines - #4683

Merged
efiacor merged 3 commits into
kptdev:mainfrom
Nordix:fix-render-displays-empty-subpkg
Aug 13, 2026
Merged

fixed render displaying sub packages without any pipelines#4683
efiacor merged 3 commits into
kptdev:mainfrom
Nordix:fix-render-displays-empty-subpkg

Conversation

@OisinJohnston2005

Copy link
Copy Markdown
Contributor

Fixes: #2053

Moved package print statement to below the empty check statement and added some tests

@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit 4ca7b26
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/6a75b73269b6220008b214d9
😎 Deploy Preview https://deploy-preview-4683--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. bug Something isn't working labels Aug 5, 2026
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@dosubot dosubot Bot added the lgtm label Aug 7, 2026
@mozesl-nokia

Copy link
Copy Markdown
Contributor

This definitely conflicts badly with #4678, which we just merged, please rebase.

Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
Signed-off-by: Oisin Johnston <oisin.johnston@ericsson.com>
@OisinJohnston2005
OisinJohnston2005 force-pushed the fix-render-displays-empty-subpkg branch from 27ceff1 to 4ca7b26 Compare August 7, 2026 10:45
@aravindtga
aravindtga requested a review from a team August 10, 2026 08:26
@aravindtga
aravindtga requested a review from a team August 11, 2026 08:40
@efiacor
efiacor merged commit a6c4a9a into kptdev:main Aug 13, 2026
28 checks passed
@efiacor
efiacor deleted the fix-render-displays-empty-subpkg branch August 13, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kpt fn render should not display subpkg name if subpkg doesn't contain any pipeline

5 participants