Fix physical quantitiy handdrawn latex#264
Merged
Merged
Conversation
…ing support in previews
peterbjohnson
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Previewing a physical-quantity LaTeX expression whose value contains LaTeX syntax, such as when from hand-drawn maths.
When previewing
\frac{x}{y} kgin compareExpressions withphysical _quantityenabled, the value (\frac{x}{y}) will be parsed directly by sympy instead of parsing via LaTeX first, causing the preview function to throw an exception.Changes
app/utility/physical_quantity_utilities.py:PhysicalQuantity._all_forms()now converts the value string throughparse_latex()before parsing it with SymPy, guarded byis_latex, mirroring the existing conversion pattern used inphysical_quantity_preview.py.app/preview_implementations/physical_quantity_preview.py: also catchtokenize.TokenErroralongsideSyntaxErrorso any other not-yet-found unconvertible-LaTeX edge case are handled correctlyapp/tests/physical_quantity_preview_test.py: addedtest_latex_physical_quantity_preview, to test various inputs for preview