Skip to content

ci: grant contents write permission to update-release-pr job - #126

Merged
kinyoklion merged 1 commit into
mainfrom
devin/1786404368-fix-release-pr-permissions
Aug 10, 2026
Merged

ci: grant contents write permission to update-release-pr job#126
kinyoklion merged 1 commit into
mainfrom
devin/1786404368-fix-release-pr-permissions

Conversation

@kinyoklion

@kinyoklion kinyoklion commented Aug 10, 2026

Copy link
Copy Markdown
Member

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

Failing run: https://github.com/launchdarkly/lua-server-sdk/actions/runs/31441985892/job/93628882965

Describe the solution you've provided

The update-release-pr job in .github/workflows/release-please.yml declared no permissions: block, so its GITHUB_TOKEN was read-only. The rockspec rename/version bump commit was created successfully, but pushing it to the release-please branch failed:

remote: Permission to launchdarkly/lua-server-sdk.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/launchdarkly/lua-server-sdk/': The requested URL returned error: 403
##[error]Process completed with exit code 128.

Adding permissions: contents: write to that job matches what the sibling release-please job already declares, and lets the composite update-versions action push its commit.

Describe alternatives you've considered

Using a PAT / app token instead of GITHUB_TOKEN. Not needed here — the default token is sufficient once the job has write scope. (Note that commits pushed with GITHUB_TOKEN do not trigger further workflow runs, which is already the existing behavior expectation for this job.)

Additional context

Single-line workflow change; no SDK code affected.

Link to Devin session: https://app.devin.ai/sessions/f93d057c29fd4a0c85554d10f9715457
Requested by: @kinyoklion


Note

Overview
The update-release-pr job in release-please.yml now declares permissions: contents: write, aligning it with the sibling release-please job.

Without write scope, the default GITHUB_TOKEN stayed read-only and pushes from the update-versions composite action failed with a 403 after rockspec commits were created locally.

Reviewed by Cursor Bugbot for commit 618dfa4. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
@kinyoklion kinyoklion self-assigned this Aug 10, 2026
@devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring

@kinyoklion
kinyoklion marked this pull request as ready for review August 10, 2026 23:26
@kinyoklion
kinyoklion requested a review from a team as a code owner August 10, 2026 23:26
@kinyoklion kinyoklion changed the title fix: grant contents write permission to update-release-pr job ci: grant contents write permission to update-release-pr job Aug 10, 2026
@kinyoklion
kinyoklion merged commit 3af1a6a into main Aug 10, 2026
21 checks passed
@kinyoklion
kinyoklion deleted the devin/1786404368-fix-release-pr-permissions branch August 10, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants