ci: grant contents write permission to update-release-pr job - #126
Merged
Conversation
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
kinyoklion
marked this pull request as ready for review
August 10, 2026 23:26
beekld
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Failing run: https://github.com/launchdarkly/lua-server-sdk/actions/runs/31441985892/job/93628882965
Describe the solution you've provided
The
update-release-prjob in.github/workflows/release-please.ymldeclared nopermissions:block, so itsGITHUB_TOKENwas read-only. The rockspec rename/version bump commit was created successfully, but pushing it to the release-please branch failed:Adding
permissions: contents: writeto that job matches what the siblingrelease-pleasejob already declares, and lets the compositeupdate-versionsaction push its commit.Describe alternatives you've considered
Using a PAT / app token instead of
GITHUB_TOKEN. Not needed here — the default token is sufficient once the job has write scope. (Note that commits pushed withGITHUB_TOKENdo not trigger further workflow runs, which is already the existing behavior expectation for this job.)Additional context
Single-line workflow change; no SDK code affected.
Link to Devin session: https://app.devin.ai/sessions/f93d057c29fd4a0c85554d10f9715457
Requested by: @kinyoklion
Note
Overview
The
update-release-prjob inrelease-please.ymlnow declarespermissions: contents: write, aligning it with the siblingrelease-pleasejob.Without write scope, the default
GITHUB_TOKENstayed read-only and pushes from theupdate-versionscomposite action failed with a 403 after rockspec commits were created locally.Reviewed by Cursor Bugbot for commit 618dfa4. Bugbot is set up for automated code reviews on this repo. Configure here.