feat: Add the FDv2 transactional store and change-set translation - #186
Open
beekld wants to merge 4 commits into
Open
feat: Add the FDv2 transactional store and change-set translation#186beekld wants to merge 4 commits into
beekld wants to merge 4 commits into
Conversation
beekld
force-pushed
the
bklimt/SDK-2691/fdv2-transactional-store
branch
from
August 10, 2026 18:41
63b58f8 to
ead1f7d
Compare
beekld
marked this pull request as ready for review
August 10, 2026 18:41
beekld
force-pushed
the
bklimt/SDK-2691/fdv2-transactional-store
branch
from
August 10, 2026 18:46
ead1f7d to
9910905
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FDv2 delivers data as change sets that must be applied to the store as atomic batches. This adds the write path for that:
TransactionalDataStoretrait, parallel toDataStore, whoseapplymethod applies a change set to the store as a single atomic batch, with an implementation for the in-memory store.FlagorSegment.Unknown object kinds in a change set are logged and skipped rather than silently ignored, matching the C++ and Java SDKs. The spec calls for silently ignoring them.
Note
Overview
Adds the FDv2 → store write path: wire change sets are converted into typed
ItemChangebatches (Flag/Segmentputs and tombstone deletes), then applied atomically via a newTransactionalDataStoretrait (implemented onInMemoryDataStore).applyhonorsNone(no-op),Full(clear flags/segments then apply changes), andPartial(merge changes only). Unknown put/delete kinds are warned and skipped; bad flag/segment JSON fails translation withserde_json::Error.Exposes
fdv2::modeland sharedChangeSetKindso stores and FDv2 share types; trait/orchestrator wiring is marked for a follow-up phase.Reviewed by Cursor Bugbot for commit 9910905. Bugbot is set up for automated code reviews on this repo. Configure here.