Fix electrum fee estimate unit mismatch (sat/vbyte vs BTC/kB) - #841
Merged
evoskuil merged 2 commits intoJul 27, 2026
Conversation
protocol_electrum::complete_estimate_fee returned the estimator's raw sat/vbyte value directly, but the electrum blockchain.estimatefee spec requires BTC/kB. Convert before responding.
evoskuil
reviewed
Jul 27, 2026
| return; | ||
| } | ||
|
|
||
| send_result(fee / satoshis_per_vbyte_to_btc_per_kilobyte, 42); |
Member
There was a problem hiding this comment.
satoshis_per_vbyte_to_btc_per_vkbyte
no_fee_estimate and satoshis_per_vbyte_to_btc_per_kilobyte name what the prior inline comments explained, so the comments are redundant.
eynhaender
force-pushed
the
fix/electrum_fee_estimator
branch
from
July 27, 2026 20:37
fd7fc72 to
b29cbd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
protocol_electrum::complete_estimate_feereturned the fee estimator's raw sat/vbyte value directly, but the electrumblockchain.estimatefeespec requires BTC/kB.-1) case is unaffected.