chore: goimports -w . && go fix ./... (go1.18) - #7
Open
coolaj86 wants to merge 1 commit into
Open
Conversation
gofmt/goimports always normalize to LF (Go issue #16355). Add .gitattributes with text=auto so Git stores LF in the repo to match, preventing spurious diffs for future contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to make a PR but it kept changing every single line, so I'm making this first to normalize line endings and formatting according to the standard Go tooling.
If there's a setting that I should apply and commit to the local git config or some other config to make this match your preferred style, I would be happy to do that instead, however, the documentation I was reading said that
go fmtdoesn't support this: golang/go#16355And supposedly Windows has fixed the related issue upstream: golang/go#16355 (comment)
I don't have a windows computer handy to easily test this, but I think this is the standard solution.