Update rpo and rev_rpo - #485
Conversation
| :returns: An alphabet order orienting every rule, or an empty word if none | ||
| exists. | ||
| :returns: The ordered alphabet, if such an alphabet exists. Otherwise, the | ||
| empty alphabet. |
There was a problem hiding this comment.
This isn't really a comment about this PR, but maybe this should return None if it can't do it.
There was a problem hiding this comment.
Do you think we should change the C++ code to return an optional, or should this be a Python only change?
|
@codex review |
james-d-mitchell
left a comment
james-d-mitchell
left a comment
There was a problem hiding this comment.
Looks good to me, let's see what Codex "thinks"
james-d-mitchell
added
the
libsemigroups-feature-not-yet-supported
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: baa1b6acb7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
2 participants
This PR updates the Python bindings to reflect the changes in libsemigroups/libsemigroups#1056. It also adds several
...RPO...objects, where previously only...RevRPO...objects existed.