test: avoid chain notifier mock deadlock - #1197
Open
starius wants to merge 1 commit into
Open
Conversation
Release the mock LND lock before sending the initial block height. A concurrent height notification can fill the buffered channel. Holding the lock while sending would then block invoice lookups and make the static loop-in test time out.
GustavoStingelin
left a comment
GustavoStingelin
left a comment
Contributor
There was a problem hiding this comment.
Why this PR? Is there any flaky test that we are trying to fix?
Collaborator
Author
|
Yes, this was identified when looking though a red CI log. |
Contributor
|
Cool, I think we should reference the failed CIs here as documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release the mock LND lock before sending the initial block height. A concurrent height notification can fill the buffered channel. Holding the lock while sending would then block invoice lookups and make the static loop-in test time out.
Pull Request Checklist
docs/release-notes/release-notes-next.md, or apply theno-changeloglabel (required by CI)