[WIP] multi: pay invoices with allowlisted components - #1198
Draft
starius wants to merge 7 commits into
Draft
Conversation
Include lightninglabs/lndclient#280 multi: migrate to btcd v2 modules + add WalletKit.SubmitPackage Migrate Loop imports and update Aperture and Taproot Assets to compatible revisions so this commit remains green on its own.
Pin the temporary lndclient tag that exposes the invoice fields required to construct SendPayment requests without forwarding encoded invoices. Remove the replacement after the upstream change is merged: lightninglabs/lndclient#286
Thread lnd clocks through the client and instant out state machine. The production default remains the wall clock while tests can inject deterministic time.
The resume fixture mistakenly reused the swap payment hash for the prepay invoice. This went unnoticed while tests identified payments by their encoded invoices. Model the distinct hashes used by the server.
Decode and validate signed invoices before constructing payment requests. Reject invoice semantics that the component API cannot safely preserve.
Build outgoing requests from validated invoice fields so encoded server invoices are never forwarded directly to LND.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode and validate signed invoices before constructing payment requests. Reject invoice semantics that the component API cannot safely preserve.
Pull Request Checklist
docs/release-notes/release-notes-next.md, or apply theno-changeloglabel (required by CI)