-
Notifications
You must be signed in to change notification settings - Fork 11
feat: add Bitcoin L1 deposit-address payment instruction #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
699ff8c
feat(quotes): add Bitcoin L1 deposit-address instruction + refundAddress
peterrojs 1f5f79e
fix(quotes): model Bitcoin L1 instruction like its cousins
298add7
fix
peterrojs 380105a
ci: bound the oasdiff breaking-changes PR comment
fa6f692
Merge branch 'main' into 07-23-grid-api-btc-l1-quote-execute-fields
peterrojs 780a497
feat(quotes): drop refundAddress from AccountDestination
6f1c00d
feat(quotes): defer refundAddress to a follow-up
fe6b43d
Merge main into the Bitcoin L1 branch
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21
openapi/components/schemas/common/PaymentBitcoinDepositAddressInfo.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| title: Bitcoin L1 Deposit Address | ||
|
peterrojs marked this conversation as resolved.
|
||
| allOf: | ||
| - $ref: ./BasePaymentAccountInfo.yaml | ||
| - type: object | ||
| required: | ||
| - address | ||
| properties: | ||
| accountType: | ||
| type: string | ||
| enum: | ||
| - BITCOIN_L1 | ||
| address: | ||
| type: string | ||
| description: On-chain Bitcoin (L1) deposit address to send funds to | ||
| example: bc1qar0srrr7xfkvy5l643lydnw9re59gtzzwf5mdq | ||
| network: | ||
| type: string | ||
| description: The blockchain network for the deposit address. | ||
| enum: | ||
| - BITCOIN | ||
| example: BITCOIN | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this :-)