Skip to content

fix(config): flatten platform fee config fixedFee to a plain integer amount - #785

Merged
jacklatourette merged 2 commits into
mainfrom
07-31-fix_config_flatten_platform_fee_config_fixedfee_to_a_plain_integer_amount
Jul 31, 2026
Merged

fix(config): flatten platform fee config fixedFee to a plain integer amount#785
jacklatourette merged 2 commits into
mainfrom
07-31-fix_config_flatten_platform_fee_config_fixedfee_to_a_plain_integer_amount

Conversation

@jacklatourette

Copy link
Copy Markdown
Contributor

The fixed fee currency is always implied by the fee config's sourceCurrency,
so the nested CurrencyAmount object was redundant. fixedFee is now the amount
in the smallest unit of the source currency.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

…amount

The fixed fee currency is always implied by the fee config's sourceCurrency,
so the nested CurrencyAmount object was redundant. fixedFee is now the amount
in the smallest unit of the source currency.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
grid-flow-builder Ready Ready Preview Jul 31, 2026 10:34pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
grid-wallet-demo Ignored Ignored Preview Jul 31, 2026 10:34pm

Request Review

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

oasdiff reports 7 error / 3 warning changes to openapi.yaml.
This PR will need approval from an API reviewer before merge.

Errors (7)

  • GET /config — the feeConfigs/items/fixedFee response's property type/format changed from object/`` to integer/`int64` for status `200` [response-property-type-changed].
  • GET /config — removed the required property feeConfigs/items/fixedFee/amount from the response with the 200 status [response-required-property-removed].
  • GET /config — removed the required property feeConfigs/items/fixedFee/currency from the response with the 200 status [response-required-property-removed].
  • PATCH /config — the feeConfigs/items/fixedFee request property type/format changed from object/`` to integer/`int64` [request-property-type-changed].
  • PATCH /config — the feeConfigs/items/fixedFee response's property type/format changed from object/`` to integer/`int64` for status `200` [response-property-type-changed].
  • PATCH /config — removed the required property feeConfigs/items/fixedFee/amount from the response with the 200 status [response-required-property-removed].
  • PATCH /config — removed the required property feeConfigs/items/fixedFee/currency from the response with the 200 status [response-required-property-removed].

Warnings (3)

Show sample
  • PATCH /config — the feeConfigs/items/fixedFee request property's min was set to 0.00 [request-property-min-set]. This is a warning because sometimes it is required to be set. But good clients should be checked to support this restriction before such change in specification.
  • PATCH /config — removed the request property feeConfigs/items/fixedFee/amount [request-property-removed].
  • PATCH /config — removed the request property feeConfigs/items/fixedFee/currency [request-property-removed].

Detected by oasdiff. Full report: job summary or the oasdiff-report artifact.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

fix(types): correct fixed-fee type to int64 in fee config

go

fix(types): change FixedFee to int64, remove CurrencyAmountParam in platform config

kotlin

fix(types): change fixedFee from CurrencyAmount to Long in FeeConfig

openapi

fix(types): simplify fixedFee to integer in FeeConfig

php

fix(types): change fixedFee from CurrencyAmount to int in FeeConfig models

python

fix(types): change fixed_fee to int in FeeConfig, remove CurrencyAmountParam

ruby

fix(types): change fixed_fee to Integer in platform_config FeeConfig

typescript

fix(types): correct fixedFee type to number in config FeeConfig
⚠️ grid-openapi studio · code

Your SDK build had at least one "warning" diagnostic.
generate ⚠️

grid-ruby studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅build ✅lint ✅test ✅

⚠️ grid-go studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@00616f127c3d5160b8e35f442bfdcea4a231efb7
⚠️ grid-kotlin studio · code

Your SDK build had a failure in the test CI job, which is a regression from the base state.
generate ⚠️build ✅lint ✅test ❗

⚠️ grid-python studio · code

Your SDK build had a failure in the lint CI job, which is a regression from the base state.
generate ✅build ✅lint ❗test ❗

pip install https://pkg.stainless.com/s/grid-python/de54f712933fe6d8d2c53786094aa3f809f96076/grid-0.0.1-py3-none-any.whl
grid-php studio · code

Your SDK build had at least one "note" diagnostic.
generate ✅lint ✅test ✅

grid-typescript studio · conflict

Your SDK build had at least one note diagnostic.

⚠️ grid-cli studio · code

Your SDK build had a failure in the build CI job, which is a regression from the base state.
generate ⚠️build ❗lint ❗test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-31 23:27:44 UTC

@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the platform fee configuration contract to represent fixedFee directly as a nonnegative smallest-unit integer.

  • Replaces the nested CurrencyAmount reference in the source FeeConfig schema with an int64.
  • Regenerates the root and Mintlify OpenAPI bundles, preserving the remaining Currency and CurrencyAmount references.

Confidence Score: 5/5

The PR appears safe to merge, with the source schema and both generated bundles consistently representing the intended flattened fee amount.

The changed contract is applied consistently, the integer constraints match existing smallest-unit monetary conventions, and the generated bundle reordering preserves all remaining shared-schema references.

Important Files Changed

Filename Overview
openapi/components/schemas/config/FeeConfig.yaml Changes fixedFee from a currency-bearing object to a nonnegative int64 whose currency is implied by sourceCurrency.
openapi.yaml Correctly reflects the source schema change in the generated OpenAPI bundle; relocated shared schemas remain present and referenced.
mintlify/openapi.yaml Remains synchronized with the root generated bundle for local Mintlify API-reference rendering.

Reviews (1): Last reviewed commit: "fix(config): flatten platform fee config..." | Re-trigger Greptile

@jacklatourette
jacklatourette merged commit ea48573 into main Jul 31, 2026
9 checks passed
@jacklatourette
jacklatourette deleted the 07-31-fix_config_flatten_platform_fee_config_fixedfee_to_a_plain_integer_amount branch July 31, 2026 23:21
@mintlify

mintlify Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🔴 Failed Jul 31, 2026, 11:50 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Introduces a breaking change to the OpenAPI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants