Skip to content

feat(config): fee config fixedFee takes an amount and a currency code - #787

Open
jacklatourette wants to merge 1 commit into
mainfrom
07-31-feat_config_fee_config_fixedfee_takes_an_amount_and_a_currency_code
Open

feat(config): fee config fixedFee takes an amount and a currency code#787
jacklatourette wants to merge 1 commit into
mainfrom
07-31-feat_config_fee_config_fixedfee_takes_an_amount_and_a_currency_code

Conversation

@jacklatourette

Copy link
Copy Markdown
Contributor

fixedFee is now an object of amount plus a plain ISO 4217 currency code,
so the fee currency is explicit without nesting the full Currency object.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

@vercel

vercel Bot commented Jul 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
grid-flow-builder Ignored Ignored Preview Jul 31, 2026 11:53pm
grid-wallet-demo Ignored Ignored Preview Jul 31, 2026 11:53pm

Request Review

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the breaking-change Introduces a breaking change to the OpenAPI spec label Jul 31, 2026
@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

⚠️ Breaking OpenAPI changes detected

oasdiff reports 5 error / 0 warning changes to openapi.yaml.
This PR will need approval from an API reviewer before merge.

Errors (5)

  • GET /config — the feeConfigs/items/fixedFee response's property type/format changed from integer/int64 to object/`` for status 200 [response-property-type-changed].
  • PATCH /config — added the new required request property feeConfigs/items/fixedFee/amount [new-required-request-property].
  • PATCH /config — added the new required request property feeConfigs/items/fixedFee/currency [new-required-request-property].
  • PATCH /config — the feeConfigs/items/fixedFee request property type/format changed from integer/int64 to object/`` [request-property-type-changed].
  • PATCH /config — the feeConfigs/items/fixedFee response's property type/format changed from integer/int64 to object/`` for status 200 [response-property-type-changed].

Detected by oasdiff. Full report: job summary or the oasdiff-report artifact.

@github-actions

github-actions Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

✱ Stainless preview builds for grid

This PR will update the grid SDKs with the following commit messages.

cli

feat(api): change fee-config fixed-fee to structured amount/currency type

go

feat(api): add amount/currency fields to fee config fixed fee

kotlin

feat(api): change fixedFee from Long to FixedFee object in fee config

openapi

fix(types): change fixedFee to object with amount and currency in fee config

php

feat(api): change fixedFee from int to object with amount/currency in FeeConfig

python

feat(api): change fixed_fee to object with amount and currency in FeeConfig

ruby

fix(api): change fixed_fee to object with amount/currency in FeeConfig

typescript

fix(api): change fixedFee to object with amount and currency in config

Edit this comment to update them. They will appear in their respective SDK's changelogs.

grid-typescript studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ✅

npm install https://pkg.stainless.com/s/grid-typescript/23cc9d8afcb64c82bf5fcabbb64076bdd1d23848/dist.tar.gz
grid-openapi studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️

grid-ruby studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ✅test ✅

grid-go studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

go get github.com/stainless-sdks/grid-go@618c718bf2918c67e2ccf1ef90856fbe8b1b2f4b
grid-kotlin studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ✅lint ✅test ❗

grid-python studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅build ✅lint ❗test ❗

pip install https://pkg.stainless.com/s/grid-python/3348884aa2b18507b8b8f1b218c9ebc5886951f8/grid-0.0.1-py3-none-any.whl
grid-php studio · code · diff

Your SDK build had at least one "note" diagnostic, but this did not represent a regression.
generate ✅lint ✅test ✅

grid-cli studio · code · diff

Your SDK build had at least one "warning" diagnostic, but this did not represent a regression.
generate ⚠️build ❗lint ❗test ❗


This comment is auto-generated by GitHub Actions and is automatically kept up to date as you push.
If you push custom code to the preview branch, re-run this workflow to update the comment.
Last updated: 2026-07-31 23:57:02 UTC

@jacklatourette
jacklatourette force-pushed the 07-31-feat_config_fee_config_fixedfee_takes_an_amount_and_a_currency_code branch from f4ab8f7 to fe42acc Compare July 31, 2026 23:41
@jacklatourette jacklatourette changed the title feat(config): fee config fixedFee takes an amount and a currency code feat(config): fee config takes flat fixedFeeAmount and fixedFeeCurrency fields Jul 31, 2026
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR changes fixedFee from a source-currency integer to an explicit amount-and-currency object.

  • Updates the modular FeeConfig source schema.
  • Regenerates the root and Mintlify OpenAPI bundles with the new shape.
  • Makes both amount and currency required when fixedFee is supplied.

Confidence Score: 4/5

This PR should not merge until the fixedFee wire-format break is placed behind the repository’s required API-version change.

The current platform configuration request and response contracts replace an integer with a required object, invalidating existing payloads and generated client types while info.version remains unchanged.

Files Needing Attention: openapi/components/schemas/config/FeeConfig.yaml and openapi/openapi.yaml

Important Files Changed

Filename Overview
openapi/components/schemas/config/FeeConfig.yaml Defines the new fixedFee object contract, but introduces a breaking type change without the required API version bump.
openapi.yaml Correctly reflects the source-schema change in the generated public bundle, including the unversioned breaking contract.
mintlify/openapi.yaml Remains synchronized with the root generated bundle and exposes the same breaking fixedFee shape to documentation consumers.
Prompt To Fix All With AI
### Issue 1
openapi/components/schemas/config/FeeConfig.yaml:19-21
**Unversioned fixed-fee type break**

When existing clients send an integer `fixedFee` to `PATCH /platform/config` or deserialize it from `GET /platform/config`, the changed schema replaces that value with a required object, causing request validation or generated-client type failures without the required API-version boundary.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: f4ab8f7 | Re-trigger Greptile

Comment thread openapi/components/schemas/config/FeeConfig.yaml
fixedFee is an object of amount plus a plain ISO 4217 currency code,
so the fee currency is explicit without nesting the full Currency object.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@jacklatourette
jacklatourette force-pushed the 07-31-feat_config_fee_config_fixedfee_takes_an_amount_and_a_currency_code branch from fe42acc to d17bf85 Compare July 31, 2026 23:53
@jacklatourette jacklatourette changed the title feat(config): fee config takes flat fixedFeeAmount and fixedFeeCurrency fields feat(config): fee config fixedFee takes an amount and a currency code Jul 31, 2026
@mintlify

mintlify Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Grid 🟢 Ready View Preview Aug 1, 2026, 1:46 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change Introduces a breaking change to the OpenAPI spec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants