LCORE-3651: fixed issue found by linter by tisnik · Pull Request #2483 · lightspeed-core/lightspeed-stack

tisnik · 2026-08-20T08:29:34Z

Description

fixed issue found by linter

Type of change

Tools used to create PR

Assisted-by: N/A
Generated by: N/A

Summary by CodeRabbit

Tests
- Updated input sanitization tests to focus on rejection reasons while ignoring normalized output.

coderabbitai · 2026-08-20T08:30:09Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e5a06698-06ad-436b-bad2-84c7984026d6

📥 Commits

Reviewing files that changed from the base of the PR and between e79fb79 and e828538.

📒 Files selected for processing (1)

tests/unit/utils/test_input_sanitization.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details

⏰ Context from checks skipped due to timeout. (25)

GitHub Check: E2E Tests for Lightspeed Evaluation job
GitHub Check: E2E: server / ci / tls
GitHub Check: E2E: server / ci / skills
GitHub Check: E2E: server / ci / rbac
GitHub Check: E2E: library / ci / other
GitHub Check: E2E: library / ci / default
GitHub Check: E2E: server / ci / mcp
GitHub Check: E2E: library / ci / skills
GitHub Check: E2E: library / ci / mcp
GitHub Check: E2E: library / ci / authorized
GitHub Check: E2E: library / ci / rbac
GitHub Check: E2E: server / ci / default
GitHub Check: E2E: server / ci / other
GitHub Check: E2E: server / ci / authorized
GitHub Check: build-pr
GitHub Check: check_dependencies
GitHub Check: ruff
GitHub Check: unit_tests (3.13)
GitHub Check: Pylinter
GitHub Check: unit_tests (3.12)
GitHub Check: spectral
GitHub Check: Red Hat Konflux / lightspeed-core-0-8-enterprise-contract / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / lightspeed-stack-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: Red Hat Konflux / rag-content-0-8-e2e-tests / lightspeed-stack-0-8
GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-0-8-on-pull-request

⚠️ CI failures not shown inline (2)

GitHub Actions: PR Title Checker / 0_check.txt: fixed issue found by linter

Conclusion: failure

View job details

##[group]Run thehanimo/pr-title-checker@v1.4.3
 with:
   GITHUB_***REDACTED_SECRET_ASSIGNMENT***
   pass_on_octokit_error: false
   configuration_path: .github/pr-title-checker-config.json
 ##[endgroup]
 (node:1983) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
 (Use `node --trace-deprecation ...` to show where the warning was created)
 Using config file .github/pr-title-checker-config.json from repo lightspeed-core/lightspeed-stack [ref: e79fb799754ff26a925930800781446f037173c0]
 (node:1983) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
 Creating label (title needs formatting)...
 Label (title needs formatting) already created.
 Adding label (title needs formatting) to PR...
 HttpError: Resource not accessible by integration
 ##[error]Failed to add label (title needs formatting) to PR

GitHub Actions: PR Title Checker / check: fixed issue found by linter

Conclusion: failure

View job details

##[group]Run thehanimo/pr-title-checker@v1.4.3
 with:
   GITHUB_***REDACTED_SECRET_ASSIGNMENT***
   pass_on_octokit_error: false
   configuration_path: .github/pr-title-checker-config.json
 ##[endgroup]
 (node:1983) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.
 (Use `node --trace-deprecation ...` to show where the warning was created)
 Using config file .github/pr-title-checker-config.json from repo lightspeed-core/lightspeed-stack [ref: e79fb799754ff26a925930800781446f037173c0]
 (node:1983) [DEP0169] DeprecationWarning: `url.parse()` behavior is not standardized and prone to errors that have security implications. Use the WHATWG URL API instead. CVEs are not issued for `url.parse()` vulnerabilities.
 Creating label (title needs formatting)...
 Label (title needs formatting) already created.
 Adding label (title needs formatting) to PR...
 HttpError: Resource not accessible by integration
 ##[error]Failed to add label (title needs formatting) to PR

🧰 Additional context used

📓 Path-based instructions (2)

**/*

📄 CodeRabbit inference engine (Custom checks)

**/*: Flag meaningful O(n^2)+ algorithms on non-trivial inputs, including handlers and Kubernetes list operations.
Flag N+1 patterns that list items and then query once per item, including Kubernetes API and database access.
Flag expensive work inside loops, including API calls, JSON parsing, and regex compilation.
Flag unbounded growth in caches, watchers, or buffers when eviction or limits are missing.
Flag missing pagination or limits on list operations and API endpoints.
Flag secrets or tokens logged in plaintext or hardcoded in source.
Flag API endpoints missing authentication or authorization.
Flag injection vulnerabilities, including SQL injection, command injection, and path traversal.
Flag sensitive data leaked in API responses, WebSocket messages, or logs.
Flag Kubernetes Secrets and Red Hat secrets missing OwnerReferences.

Files:

tests/unit/utils/test_input_sanitization.py

tests/unit/**/*.py

📄 CodeRabbit inference engine (AGENTS.md)

Use pytest for unit tests, shared fixtures in conftest.py, pytest-mock for mocks, pytest.mark.asyncio for async tests, and maintain at least 60% unit-test coverage.

Files:

tests/unit/utils/test_input_sanitization.py

🔇 Additional comments (1)

tests/unit/utils/test_input_sanitization.py (1)

252-271: LGTM!

Walkthrough

The change updates sanitization rejection tests to ignore normalized output from sanitize_input. Rejection-reason assertions remain unchanged.

Changes

Sanitization Test Cleanup

Layer / File(s)	Summary
Rejection test assertions `tests/unit/utils/test_input_sanitization.py`	The tests assign only the rejection reason returned by `sanitize_input`. Existing assertions and test behavior remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e8285

This localized test-only refactor introduces no actionable merge-blocking risk and is merge-ready after normal checks and review.

Possibly related PRs

lightspeed-core/lightspeed-stack#2476: Updates sanitize_input tests in the same file and covers the related function behavior.

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Performance And Algorithmic Complexity	✅ Passed	The pull request changes only four test assignments from `normalized` to `_`; no production files or runtime algorithms changed, so it introduces no listed performance risk.
Security And Secret Handling	✅ Passed	The PR only changes four unit-test assignments from `normalized` to `_`; no secrets, auth, injection, sensitive output, or Kubernetes Secret metadata changes were introduced.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title identifies the linter-related fix, which matches the pull request objective and test changes.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests

✨ Simplify code

Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

fixed issue found by linter

e828538

tisnik changed the title ~~fixed issue found by linter~~ LCORE-3651: fixed issue found by linter Aug 20, 2026

tisnik merged commit 7ae6f29 into lightspeed-core:main Aug 20, 2026
39 of 42 checks passed

Navigation Menu

Uh oh!

LCORE-3651: fixed issue found by linter - #2483

LCORE-3651: fixed issue found by linter#2483
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:fixed-issue-found-by-linter

tisnik commented Aug 20, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

tisnik commented Aug 20, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Tools used to create PR

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

tisnik commented Aug 20, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading