Skip to content

LCORE-3521: Rewrite container lifecycle test as a single end-to-end cycle #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jazzcort wants to merge 3 commits into
base: main
Choose a base branch
from
+190 −682
Open

LCORE-3521: Rewrite container lifecycle test as a single end-to-end cycle #2492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c096af8
LCORE-3521: Rewrite container lifecycle test as a single end-to-end c…
Jazzcort Aug 20, 2026
4af604c
Make the health check less strict
Jazzcort Aug 20, 2026
60df6bb
Change the health check logic in Makefile
Jazzcort Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ start-llama-stack-container: build-llama-stack-image ## Start llama-stack contai
-p $(LLAMA_STACK_PORT):8321 \
--health-cmd "curl -f http://localhost:8321/v1/health || exit 1" \
--health-interval 10s \
--health-timeout 5s \
--health-retries 3 \
--health-start-period 15s \
--health-timeout 10s \
--health-retries 5 \
--health-start-period 20s \
-v $(PWD)/$(LLAMA_STACK_CONFIG):/opt/app-root/run.yaml:z \
-v $(PWD)/$(CONFIG):/opt/app-root/lightspeed-stack.yaml:ro,z \
-v $(PWD)/scripts/llama-stack-entrypoint.sh:/opt/app-root/enrich-entrypoint.sh:ro,z \
Expand Down Expand Up @@ -123,12 +123,11 @@ start-llama-stack-container: build-llama-stack-image ## Start llama-stack contai
wait-for-llama-stack-health: ## Wait for llama-stack container to be healthy
@echo "Waiting for llama-stack container to be healthy..."
@for i in {1..30}; do \
STATUS=$$($(CONTAINER_RUNTIME) inspect --format='{{.State.Health.Status}}' $(LLAMA_STACK_CONTAINER_NAME) 2>/dev/null || echo "no-healthcheck"); \
if [ "$$STATUS" = "healthy" ]; then \
if curl -sf http://localhost:$(LLAMA_STACK_PORT)/v1/health >/dev/null 2>&1; then \
echo "✓ Llama-stack is healthy and ready!"; \
exit 0; \
fi; \
echo " Health status: $$STATUS (attempt $$i/30)"; \
echo " Waiting... (attempt $$i/30)"; \
sleep 2; \
done; \
echo "✗ ERROR: Llama-stack did not become healthy within 60 seconds"; \
Expand Down
Loading
Loading