Skip to content

Add missing required and drop unnecessary required - #126

Draft
Yang-33 wants to merge 18 commits into
mainfrom
required-optionals
Draft

Add missing required and drop unnecessary required#126
Yang-33 wants to merge 18 commits into
mainfrom
required-optionals

Conversation

@Yang-33

@Yang-33 Yang-33 commented Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

There is an inconsistency between the OpenAPI specification (and generated SDKs) and the actual API behavior.
This change updates the required or optional annotations to match the actual behavior.

The behavior of the Messaging API itself is unchanged at all. This is purely a bug fix for the OpenAPI spec and the generated SDKs.

Affected methods

operationId parameter fix
createAudienceGroup description missing required
createAudienceForUploadingUserIds description missing required
addAudienceToAudienceGroup audienceGroupId missing required
- audiences missing required
addUserIdsToAudience audienceGroupId missing required
createClickBasedAudienceGroup description missing required
- requestId missing required
createImpBasedAudienceGroup description missing required
- requestId missing required
updateAudienceGroupDescription description missing required
getNumberOfFollowers date incorrectly marked as optional
createRichMenu / validateRichMenuObject size, selected, name, chatBarText, areas missing required
createCoupon reward missing required
getSharedAudienceGroups page incorrectly marked as required

bot sdks we must fix

we must fix test depending on this.
go, ruby, nodejs, java are affected. line-openapi-126-prepare branch has this fix.
also 5c8b8c4 tested these remote branches, and https://github.com/line/line-openapi/actions/runs/31403474364?pr=126 showed all jobs were passed.

Yang-33 added 15 commits June 25, 2026 11:09
@Yang-33
Add required: description for CreateAudienceGroupRequest
e005aa3
@Yang-33
Add required: description for createAudienceForUploadingUserIds
0c3726c
@Yang-33
Add required: audienceGroupId for AddAudienceToAudienceGroupRequest
682bafb
@Yang-33
Add required: audiences for AddAudienceToAudienceGroupRequest
f280ccc
@Yang-33
Add required: audienceGroupId for addUserIdsToAudience
7a9945e
@Yang-33
Add required: description for CreateClickBasedAudienceGroupRequest
83a1501
@Yang-33
Add required: requestId for CreateClickBasedAudienceGroupRequest
0317c28
@Yang-33
Add required: description for CreateImpBasedAudienceGroupRequest
3bb8877
@Yang-33
Add required: requestId for CreateImpBasedAudienceGroupRequest
d25a362
@Yang-33
Add required: description for UpdateAudienceGroupDescriptionRequest
30634d9
@Yang-33
Fix required: true for getNumberOfFollowers date parameter
6eee38f
@Yang-33
Add required fields for RichMenuRequest to fix SDK parameters
5e322b0
@Yang-33
Add required: reward for CouponCreateRequest
2af5fcd
@Yang-33
Fix required: false for getSharedAudienceGroups page parameter
146039f
@Yang-33
Merge branch 'main' into required-optionals
690a65b
@Yang-33

Yang-33 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

I'll prepare the test changes for some repositories first, then open the PR.

@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first.

@github-actions github-actions Bot closed this Jul 14, 2026
@Yang-33 Yang-33 reopened this Jul 14, 2026
@Yang-33 Yang-33 added the keep Avoid auto close label Jul 14, 2026
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first.

@github-actions github-actions Bot closed this Jul 29, 2026
@Yang-33 Yang-33 reopened this Jul 30, 2026
@Yang-33 Yang-33 mentioned this pull request Aug 10, 2026
Merged
Yang-33 added a commit to line/line-bot-sdk-nodejs that referenced this pull request Aug 14, 2026
@Yang-33
Omit undefined multipart fields (#1775)
6348819 
For form parameters, `undefined` values are not always omitted. This
change fixes that behavior.

Also, `description` is required for the
`createAudienceForUploadingUserIds` API, but our OpenAPI definition
appears to be incorrect. I will fix that separately in PR
line/line-openapi#126.

For now, let's merge this change first.
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request was closed because it has been inactive for 14 days. Please reopen if you still intend to submit this pull request, or submit issues at first.

@github-actions github-actions Bot closed this Aug 25, 2026
@Yang-33 Yang-33 reopened this Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

JAVA

You can check generated code in java

Check the diff here

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

NODEJS

You can check generated code in nodejs

Check the diff here

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

PHP

You can check generated code in php

Check the diff here

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

PYTHON

You can check generated code in python

Check the diff here

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

RUBY

You can check generated code in ruby

Check the diff here

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown

GO

You can check generated code in go

Check the diff here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

keep Avoid auto close

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Yang-33