[test] implement proper cleanup of reserved IPs in e2e tests - #603
Merged
Conversation
moshevayner
force-pushed
the
reserved-ips-e2e-fix
branch
from
August 3, 2026 17:43
da6d655 to
6246a32
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #603 +/- ##
=======================================
Coverage 73.76% 73.76%
=======================================
Files 19 19
Lines 3045 3045
=======================================
Hits 2246 2246
Misses 538 538
Partials 261 261 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
moshevayner
force-pushed
the
reserved-ips-e2e-fix
branch
from
August 3, 2026 20:24
6246a32 to
d121444
Compare
Signed-off-by: Moshe Vayner <moshe@vayner.me>
moshevayner
force-pushed
the
reserved-ips-e2e-fix
branch
from
August 4, 2026 17:49
d121444 to
07efb86
Compare
AshleyDumaine
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes intermittent reserved-IP leaks from e2e tests.
Reserved IPs created directly through the Linode API were not always released when setup or cleanup failed. This could exhaust the shared CI account's reserved-IP capacity.
Changes
404as an idempotent successful release.cleanup-cluster.release <ip>sweepSafety
The fallback sweep only releases reserved IPs tagged for the current CI run. It does not touch unrelated account resources.
Validation
chainsaw lintfor all modified e2e manifestsmake -n cleanup-clusterSigned-off-by: Moshe Vayner moshe@vayner.me
General:
Pull Request Guidelines: