Skip to content

Integration test fixes#715

Open
zliang-akamai wants to merge 5 commits into
linode:devfrom
zliang-akamai:zhiwei/fix-test-07132026
Open

Integration test fixes#715
zliang-akamai wants to merge 5 commits into
linode:devfrom
zliang-akamai:zhiwei/fix-test-07132026

Conversation

@zliang-akamai

@zliang-akamai zliang-akamai commented Jul 13, 2026

Copy link
Copy Markdown
Member

Description

  • Fix Object Storage bucket creation so the bucket region is initialized correctly
  • Remove outdated LKE cluster dashboard URL tests
  • Merge and fix Linode type override coverage with the existing Linode types test

Testing

pytest test/integration/models/vpc/test_vpc.py -k test_get_vpc_ipv6s
pytest test/integration/models/linode/test_linode.py -k test_get_linode_types
pytest test/unit/linode_client_test.py -k test_bucket_create

@zliang-akamai zliang-akamai requested review from a team as code owners July 13, 2026 15:28
@zliang-akamai zliang-akamai requested review from mawilk90 and yec-akamai and removed request for a team July 13, 2026 15:28
@zliang-akamai zliang-akamai added the ignore-for-release PRs you do not want to render in the changelog label Jul 13, 2026
yec-akamai
yec-akamai previously approved these changes Jul 13, 2026

@yec-akamai yec-akamai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting up the fix!

@zliang-akamai zliang-akamai requested review from a team, Copilot, mgwoj and psnoch-akamai and removed request for a team July 13, 2026 16:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Object Storage bucket creation path to construct ObjectStorageBucket instances with the correct derived parent ID (region/cluster), and cleans up/adjusts tests to match current LKE behavior and improve Linode type pricing coverage.

Changes:

  • Update bucket_create to use ObjectStorageBucket.make_instance(...) so the bucket’s derived region parent ID is sourced from the response JSON when available.
  • Remove outdated LKE cluster dashboard URL tests (unit + integration).
  • Fold Linode type override coverage into the existing Linode types integration test.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/unit/objects/lke_test.py Removes unit coverage for deprecated/removed LKE dashboard URL view behavior.
test/unit/linode_client_test.py Adds an assertion around the created bucket’s region value.
test/integration/models/lke/test_lke.py Removes integration coverage for deprecated/removed LKE dashboard URL view behavior (and unused import).
test/integration/models/linode/test_linode.py Merges Linode type override checks into the main Linode types test (but currently contains a no-op check).
linode_api4/groups/object_storage.py Uses ObjectStorageBucket.make_instance so derived bucket instances pick up the correct parent region/cluster from API JSON.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/integration/models/linode/test_linode.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore-for-release PRs you do not want to render in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants