Integration test fixes#715
Open
zliang-akamai wants to merge 5 commits into
Open
Conversation
yec-akamai
previously approved these changes
Jul 13, 2026
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Thanks for putting up the fix!
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Object Storage bucket creation path to construct ObjectStorageBucket instances with the correct derived parent ID (region/cluster), and cleans up/adjusts tests to match current LKE behavior and improve Linode type pricing coverage.
Changes:
- Update
bucket_createto useObjectStorageBucket.make_instance(...)so the bucket’s derivedregionparent ID is sourced from the response JSON when available. - Remove outdated LKE cluster dashboard URL tests (unit + integration).
- Fold Linode type override coverage into the existing Linode types integration test.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/unit/objects/lke_test.py | Removes unit coverage for deprecated/removed LKE dashboard URL view behavior. |
| test/unit/linode_client_test.py | Adds an assertion around the created bucket’s region value. |
| test/integration/models/lke/test_lke.py | Removes integration coverage for deprecated/removed LKE dashboard URL view behavior (and unused import). |
| test/integration/models/linode/test_linode.py | Merges Linode type override checks into the main Linode types test (but currently contains a no-op check). |
| linode_api4/groups/object_storage.py | Uses ObjectStorageBucket.make_instance so derived bucket instances pick up the correct parent region/cluster from API JSON. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
yec-akamai
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing