blk-mq-dma: kernel-doc fixes - #112
Conversation
|
Upstream branch: 8d3ae59 |
2225f0a to
c64cb66
Compare
|
Upstream branch: ff68e5f |
00e64dd to
27c11c3
Compare
c64cb66 to
f44f344
Compare
|
Upstream branch: 0f23d56 |
27c11c3 to
475d24c
Compare
f44f344 to
9bee990
Compare
|
Upstream branch: 1200d84 |
475d24c to
eb0bcaa
Compare
9bee990 to
87a06b3
Compare
|
Upstream branch: 3a0dd7b |
eb0bcaa to
2ae3a32
Compare
87a06b3 to
f2b91d1
Compare
|
Upstream branch: b126f6f |
2ae3a32 to
fc71201
Compare
f2b91d1 to
da1ee34
Compare
|
Upstream branch: bd5f485 |
fc71201 to
6af9ca8
Compare
da1ee34 to
45acce2
Compare
|
Upstream branch: 59e6295 |
6af9ca8 to
d4126f8
Compare
45acce2 to
c54091c
Compare
|
Upstream branch: 98f21c5 |
d4126f8 to
7670f6f
Compare
c54091c to
f28d8dc
Compare
|
Upstream branch: cb8a75e |
7670f6f to
a1e7d5b
Compare
f28d8dc to
3705daf
Compare
|
Upstream branch: a4ff2be |
a1e7d5b to
c95de08
Compare
3705daf to
98a2d8e
Compare
|
Upstream branch: 9d2ed02 |
c95de08 to
83adeb5
Compare
98a2d8e to
96fc384
Compare
|
Upstream branch: c84d3e3 |
83adeb5 to
4f7b989
Compare
96fc384 to
deee96f
Compare
|
Upstream branch: 77ae27f |
1 similar comment
|
Upstream branch: 77ae27f |
deee96f to
7d4b639
Compare
|
Upstream branch: 7f063b2 |
4f7b989 to
798fdcd
Compare
7d4b639 to
e00fc7c
Compare
|
Upstream branch: 818bebe |
798fdcd to
1f0eaa7
Compare
e00fc7c to
787bdf5
Compare
blk_rq_integrity_dma_map_iter_next() documents a @State parameter it has never had. It takes (req, dma_dev, iter), as declared in include/linux/blk-integrity.h, so scripts/kernel-doc reports an "Excess function parameter 'state' description" warning at block/blk-mq-dma.c:379. The wrapped summary lines of both integrity helpers also indent with tabs directly after "* ", which checkpatch flags as: block/blk-mq-dma.c:320: WARNING: please, no space before tabs block/blk-mq-dma.c:361: WARNING: please, no space before tabs Drop the stale parameter description and use spaces for the alignment; the rendered output is unchanged. No functional change. Both issues were found by running scripts/kernel-doc and scripts/checkpatch.pl over block/, and verified against the prototype in include/linux/blk-integrity.h. Fixes: fec9b16 ("blk-mq-dma: add scatter-less integrity data DMA mapping") Assisted-by: Claude:claude-opus-5 kernel-doc checkpatch Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
blk_rq_dma_map_iter_start() and blk_rq_dma_map_iter_next() both document their return value as "%true ft it did map a segment", where "ft" should read "if". The two integrity variants further down spell it correctly. No functional change. Fixes: 858299d ("block: add scatterlist-less DMA mapping helpers") Assisted-by: Claude:claude-opus-5 Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
|
Upstream branch: 531ed94 |
1f0eaa7 to
f5f85a5
Compare
1 participant
Pull request for series with
subject: blk-mq-dma: kernel-doc fixes
version: 1
url: http://redsun45:8000/project/linux-block/list/?series=636