partitions/efi: reject GPT entries with starting_lba > ending_lba - #1043
Open
blktests-ci[bot] wants to merge 1 commit into
Open
partitions/efi: reject GPT entries with starting_lba > ending_lba#1043blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 2d2338c |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 6, 2026 09:20
c0cc428 to
23d8cf0
Compare
Author
|
Upstream branch: 0d83957 |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 6, 2026 10:11
1206188 to
f43a58c
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
August 9, 2026 07:24
612ae31 to
863d43a
Compare
Author
|
Upstream branch: 06cf618 |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 9, 2026 08:48
f43a58c to
c2c5e98
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 10, 2026 22:28
863d43a to
29ac21d
Compare
Author
|
Upstream branch: d58772d |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 10, 2026 23:18
c2c5e98 to
100ed63
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 12, 2026 13:27
29ac21d to
ea2c39d
Compare
Author
|
Upstream branch: f5bbbfe |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 12, 2026 14:54
100ed63 to
d3f02b5
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 12, 2026 18:56
ea2c39d to
4082a30
Compare
Author
|
Upstream branch: 3d6d817 |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 12, 2026 20:07
d3f02b5 to
f6c395a
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 13, 2026 19:18
4082a30 to
36bd7eb
Compare
Author
|
Upstream branch: 3aa1dca |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 13, 2026 21:03
f6c395a to
28f102e
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
August 16, 2026 18:34
d89ab11 to
fdba928
Compare
Author
|
Upstream branch: fd923b3 |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 16, 2026 21:12
28f102e to
52f3b2f
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 17, 2026 14:10
fdba928 to
60442a3
Compare
Author
|
Upstream branch: 8d3ae59 |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 17, 2026 20:36
52f3b2f to
0cfa40f
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 19, 2026 05:25
60442a3 to
3df366e
Compare
is_pte_valid() checks that both LBAs of a GPT partition entry are within the device, but never that the entry describes a forward range: if ((!efi_guidcmp(pte->partition_type_guid, NULL_GUID)) || le64_to_cpu(pte->starting_lba) > lastlba || le64_to_cpu(pte->ending_lba) > lastlba) return 0; EndingLBA is defined as the last LBA of the partition, so a conforming entry always has StartingLBA <= EndingLBA. A crafted table can invert the two while keeping both within the device, and efi_partition() then computes the length as u64 size = le64_to_cpu(ptes[i].ending_lba) - le64_to_cpu(ptes[i].starting_lba) + 1ULL; which underflows to a value close to U64_MAX. The "extends beyond EOD" clamp in blk_add_partition() does not contain this, because it tests if (from + size > get_capacity(disk)) and from + size wraps for a size of that magnitude, so the sum comes out small, the clamp is skipped and the partition is registered with the underflowed length. From then on bio_check_eod() is evaluated against bdev_nr_sectors() of that partition, i.e. against the bogus length, so I/O submitted through the partition device is no longer confined to the partition and reaches sectors owned by other partitions of the same disk. This was verified on 6.8.12 with a crafted two partition image: the inverted entry is registered as a partition of nearly 2^64 sectors with no "extends beyond EOD" warning, and BLKZEROOUT issued on that partition overwrote known marker data belonging to the other, unrelated partition on the same disk. No privileged step is needed on the victim side beyond getting the table parsed, which happens automatically for removable media on a typical desktop. Reject the inverted range in is_pte_valid(), the single place every GPT entry is gated on. The code has been this way since the beginning of git history. Fixes: 1da177e ("Linux-2.6.12-rc2") Cc: stable@vger.kernel.org Signed-off-by: Nguyen Le Thanh Tung <nguyenlethanhtung555@gmail.com>
Author
|
Upstream branch: bd5f485 |
blktests-ci
Bot
force-pushed
the
series/1134859=>linus-master
branch
from
August 19, 2026 07:11
0cfa40f to
b852501
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: partitions/efi: reject GPT entries with starting_lba > ending_lba
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1134859