Skip to content

blk-cgroup: fix use-after-free in blkg_conf_open_bdev - #1143

Open
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1146329=>linus-master
Open

blk-cgroup: fix use-after-free in blkg_conf_open_bdev#1143
blktests-ci[bot] wants to merge 1 commit into
linus-master_basefrom
series/1146329=>linus-master

Conversation

@blktests-ci

@blktests-ci blktests-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown

Pull request for series with
subject: blk-cgroup: fix use-after-free in blkg_conf_open_bdev
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1146329

@blktests-ci

blktests-ci Bot commented Aug 14, 2026

Copy link
Copy Markdown
Author

Upstream branch: 3aa1dca
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146329
version: 1

@blktests-ci
blktests-ci Bot force-pushed the linus-master_base branch 2 times, most recently from d89ab11 to fdba928 Compare August 16, 2026 18:34
@blktests-ci

blktests-ci Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Upstream branch: fd923b3
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146329
version: 1

@blktests-ci
blktests-ci Bot force-pushed the series/1146329=>linus-master branch from 4c1f92f to 4c01fef Compare August 16, 2026 19:52
@blktests-ci
blktests-ci Bot force-pushed the linus-master_base branch from fdba928 to 60442a3 Compare August 17, 2026 14:10
@blktests-ci

blktests-ci Bot commented Aug 17, 2026

Copy link
Copy Markdown
Author

Upstream branch: 8d3ae59
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146329
version: 1

@blktests-ci
blktests-ci Bot force-pushed the series/1146329=>linus-master branch from 4c01fef to aae5820 Compare August 17, 2026 16:40
@blktests-ci
blktests-ci Bot force-pushed the linus-master_base branch from 60442a3 to 3df366e Compare August 19, 2026 05:25
blkg_conf_open_bdev() holds rq_qos_mutex while checking whether the disk is
still live. On the dead-disk error path, it drops the bdev reference before
unlocking the mutex.

Once that reference is dropped, a concurrent put_disk() can release the
remaining device reference and free the bdev. The subsequent mutex_unlock()
then dereferences bdev->bd_queue from the freed object.

Unlock rq_qos_mutex while the local bdev reference still pins the object.
Drop the reference only after the final bdev access.

Fixes: a13bd91 ("block/rq_qos: protect rq_qos apis with a new lock")
Cc: stable@vger.kernel.org
Signed-off-by: Shuangpeng Bai <shuangpeng.kernel@gmail.com>
@blktests-ci

blktests-ci Bot commented Aug 19, 2026

Copy link
Copy Markdown
Author

Upstream branch: bd5f485
series: https://patchwork.kernel.org/project/linux-block/list/?series=1146329
version: 1

@blktests-ci
blktests-ci Bot force-pushed the series/1146329=>linus-master branch from aae5820 to ba854f7 Compare August 19, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant