blk-mq-dma: kernel-doc fixes - #1146
Open
blktests-ci[bot] wants to merge 2 commits into
Open
Conversation
Author
|
Upstream branch: 3aa1dca |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
2 times, most recently
from
August 16, 2026 18:34
d89ab11 to
fdba928
Compare
Author
|
Upstream branch: fd923b3 |
blktests-ci
Bot
force-pushed
the
series/1146755=>linus-master
branch
from
August 16, 2026 19:33
3074e68 to
5d30e7c
Compare
Author
|
Upstream branch: fd923b3 |
blktests-ci
Bot
force-pushed
the
series/1146755=>linus-master
branch
from
August 17, 2026 07:53
5d30e7c to
0b0220c
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 17, 2026 14:10
fdba928 to
60442a3
Compare
Author
|
Upstream branch: 8d3ae59 |
blktests-ci
Bot
force-pushed
the
series/1146755=>linus-master
branch
from
August 17, 2026 14:19
0b0220c to
262ec73
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 19, 2026 05:25
60442a3 to
3df366e
Compare
blk_rq_integrity_dma_map_iter_next() documents a @State parameter it has never had. It takes (req, dma_dev, iter), as declared in include/linux/blk-integrity.h, so scripts/kernel-doc reports an "Excess function parameter 'state' description" warning at block/blk-mq-dma.c:379. The wrapped summary lines of both integrity helpers also indent with tabs directly after "* ", which checkpatch flags as: block/blk-mq-dma.c:320: WARNING: please, no space before tabs block/blk-mq-dma.c:361: WARNING: please, no space before tabs Drop the stale parameter description and use spaces for the alignment; the rendered output is unchanged. No functional change. Both issues were found by running scripts/kernel-doc and scripts/checkpatch.pl over block/, and verified against the prototype in include/linux/blk-integrity.h. Fixes: fec9b16 ("blk-mq-dma: add scatter-less integrity data DMA mapping") Assisted-by: Claude:claude-opus-5 kernel-doc checkpatch Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
blk_rq_dma_map_iter_start() and blk_rq_dma_map_iter_next() both document their return value as "%true ft it did map a segment", where "ft" should read "if". The two integrity variants further down spell it correctly. No functional change. Fixes: 858299d ("block: add scatterlist-less DMA mapping helpers") Assisted-by: Claude:claude-opus-5 Signed-off-by: Bryan Boquel <boquelbryan6@gmail.com> Reviewed-by: Christoph Hellwig <hch@lst.de>
Author
|
Upstream branch: bd5f485 |
blktests-ci
Bot
force-pushed
the
series/1146755=>linus-master
branch
from
August 19, 2026 05:29
262ec73 to
4b9412a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: blk-mq-dma: kernel-doc fixes
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1146755