nbd: clamp the timeout before converting it to jiffies - #1149
Open
blktests-ci[bot] wants to merge 1 commit into
Open
nbd: clamp the timeout before converting it to jiffies#1149blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 8d3ae59 |
Author
|
Upstream branch: 8d3ae59 |
blktests-ci
Bot
force-pushed
the
series/1147249=>linus-master
branch
from
August 18, 2026 07:21
d227a60 to
c8a794b
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
August 19, 2026 05:25
60442a3 to
3df366e
Compare
nbd_set_cmd_timeout() stores timeout * HZ into tag_set.timeout, an unsigned int, and passes the same product to blk_queue_rq_timeout() without any range check. A large timeout (2^32 seconds, say) truncates to 0 instead of being a very long timeout. Clamp the timeout to UINT_MAX / HZ seconds first. Setting NBD_SET_TIMEOUT to 2^32 left the debugfs timeout at 0 before this change and at 4294967000 after it. Fixes: 55313e9 ("nbd: add set cmd timeout helper") Signed-off-by: Tao Cui <cuitao@kylinos.cn> Reviewed-by: Yu Kuai <yukuai@fygo.io>
Author
|
Upstream branch: bd5f485 |
blktests-ci
Bot
force-pushed
the
series/1147249=>linus-master
branch
from
August 19, 2026 05:48
c8a794b to
33bd540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: nbd: clamp the timeout before converting it to jiffies
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1147249