Skip to content

media: i2c: Expand gain values for ov5693 #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
djrscally wants to merge 1 commit into
base: v6.19-surface-devel
Choose a base branch
from
Open

media: i2c: Expand gain values for ov5693 #168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions drivers/media/i2c/ov5693.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,10 @@

/* Analogue Gain */
#define OV5693_GAIN_CTRL_REG CCI_REG16(0x350a)
#define OV5693_GAIN_CTRL_MASK GENMASK(10, 4)
#define OV5693_GAIN_CTRL_MASK GENMASK(10, 0)
#define OV5693_GAIN_MIN 1
#define OV5693_GAIN_MAX 127
#define OV5693_GAIN_DEF 8
#define OV5693_GAIN_MAX 2047
#define OV5693_GAIN_DEF 16
#define OV5693_GAIN_STEP 1

/* Digital Gain */
Expand Down Expand Up @@ -444,7 +444,7 @@ static int ov5693_analog_gain_configure(struct ov5693_device *ov5693, u32 gain)
{
int ret = 0;

gain = (gain << 4) & OV5693_GAIN_CTRL_MASK;
gain &= OV5693_GAIN_CTRL_MASK;

cci_write(ov5693->regmap, OV5693_GAIN_CTRL_REG, gain, &ret);

Expand Down