Skip to content

Fix missing identities on CLAs - prod - #5161

Merged
lukaszgryglicki merged 1 commit into
mainfrom
unicron-missing-cla-signed-by-identities-in-my-clas-api-prod
Aug 26, 2026
Merged

Fix missing identities on CLAs - prod#5161
lukaszgryglicki merged 1 commit into
mainfrom
unicron-missing-cla-signed-by-identities-in-my-clas-api-prod

Conversation

@lukaszgryglicki

Copy link
Copy Markdown
Member

Fixes: linuxfoundation/lfx-self-serve#1860

cc @mlehotskylf @ahmedomosanya

Signed-off-by: Łukasz Gryglicki lgryglicki@cncf.io

Assisted by OpenAI

Assisted by GitHub Copilot

Assisted by Claude

Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io>

Assisted by [OpenAI](https://platform.openai.com/)

Assisted by [GitHub Copilot](https://github.com/features/copilot)

Assisted by [Claude](https://claude.ai)
@lukaszgryglicki lukaszgryglicki self-assigned this Aug 26, 2026
Copilot AI balanced review requested due to automatic review settings August 26, 2026 17:41
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e9e498c8-285e-45c1-b4a7-e27867f70a0a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ports the missing “Signed as” identity fix to production.

Changes:

  • Resolves identities from signature and user records.
  • Preserves and stamps identity metadata during signing.
  • Adds DynamoDB repair behavior and tests.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
v2/sign/service.go Preserves and stamps signer identity.
v2/sign/identity_stamp_test.go Tests identity stamping and regeneration.
v2/my_clas/service.go Adds identity fallback resolution.
v2/my_clas/service_test.go Tests fallback behavior.
v2/my_clas/cla_managers_test.go Expands identity integration tests.
v2/dynamo_events/service.go Registers modify-event identity repair.
swagger/common/my-cla.yaml Updates identity API documentation.
signatures/service.go Exposes raw signature retrieval.
signatures/repository.go Adds missing-field backfill logic.
signatures/mocks/mock_service.go Updates generated service mock.
signatures/dbmodels.go Preserves additional signature attributes.
Files not reviewed (1)
  • cla-backend-go/signatures/mocks/mock_service.go: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cla-backend-go/v2/my_clas/service.go
Comment thread cla-backend-go/v2/dynamo_events/service.go
Comment thread cla-backend-go/signatures/repository.go
Comment thread cla-backend-go/swagger/common/my-cla.yaml
@lukaszgryglicki
lukaszgryglicki merged commit 8263d56 into main Aug 26, 2026
8 checks passed
@lukaszgryglicki
lukaszgryglicki deleted the unicron-missing-cla-signed-by-identities-in-my-clas-api-prod branch August 26, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants