Fix missing identities on CLAs - prod - #5161
Conversation
Signed-off-by: Łukasz Gryglicki <lgryglicki@cncf.io> Assisted by [OpenAI](https://platform.openai.com/) Assisted by [GitHub Copilot](https://github.com/features/copilot) Assisted by [Claude](https://claude.ai)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Ports the missing “Signed as” identity fix to production.
Changes:
- Resolves identities from signature and user records.
- Preserves and stamps identity metadata during signing.
- Adds DynamoDB repair behavior and tests.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
v2/sign/service.go |
Preserves and stamps signer identity. |
v2/sign/identity_stamp_test.go |
Tests identity stamping and regeneration. |
v2/my_clas/service.go |
Adds identity fallback resolution. |
v2/my_clas/service_test.go |
Tests fallback behavior. |
v2/my_clas/cla_managers_test.go |
Expands identity integration tests. |
v2/dynamo_events/service.go |
Registers modify-event identity repair. |
swagger/common/my-cla.yaml |
Updates identity API documentation. |
signatures/service.go |
Exposes raw signature retrieval. |
signatures/repository.go |
Adds missing-field backfill logic. |
signatures/mocks/mock_service.go |
Updates generated service mock. |
signatures/dbmodels.go |
Preserves additional signature attributes. |
Files not reviewed (1)
- cla-backend-go/signatures/mocks/mock_service.go: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Fixes: linuxfoundation/lfx-self-serve#1860
cc @mlehotskylf @ahmedomosanya
Signed-off-by: Łukasz Gryglicki lgryglicki@cncf.io
Assisted by OpenAI
Assisted by GitHub Copilot
Assisted by Claude