fix(storage): resolve Windows SQL file paths - #696
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
=======================================
Coverage 77.39% 77.39%
=======================================
Files 486 486
Lines 68281 68287 +6
Branches 9405 9406 +1
=======================================
+ Hits 52847 52853 +6
Misses 12024 12024
Partials 3410 3410
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cofin
marked this pull request as ready for review
August 10, 2026 21:17
cofin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #693.
StorageRegistry.get()built Windows local paths asfile://C:\\..., which placed the drive path in the URI authority and left the filesystem path empty.This centralizes local backend URI construction with an empty authority, adds nested
Pathand Windows drive-path coverage, and exercises named SQL file loading in the compiled-wheel smoke.Validation: focused storage/loader/mypyc tests, standalone mypyc smoke, and repository lint/type checks.