TEL-730: Update various SIP validation methods to return error slices.#1666
Closed
alexfish8 wants to merge 2 commits into
Closed
TEL-730: Update various SIP validation methods to return error slices.#1666alexfish8 wants to merge 2 commits into
alexfish8 wants to merge 2 commits into
Conversation
|
Contributor
Author
|
Closed in favor of #1667. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: we'd like like to get a better sense as to which clients are sending invalid REFER messages (see TEL-730). In order to do so, we're updating various SIP validation methods to return slices of errors. Some of these errors might be "soft errors" (i.e., encountering them shouldn't cause the surrounding request to fail). Previously, these soft errors were could be iterated over via a global
SoftFailureNotifier. The global nature of this notifier made it cumbersome to log these soft errors with request-scoped loggers. This PR updates the validation methods to include these soft errors in their return values so that callers may log them as they please.A few additional notes:
errreturn values to[]errorunless I needed to do so.LogSoftErrors).TODO: Maintain backwards compatibility so that we don't have to do a major version bump.