Add Product → Hero 3D playbook landing page at /hero-3d-playbook - #86
Add Product → Hero 3D playbook landing page at /hero-3d-playbook#86salinsug wants to merge 1 commit into
Conversation
Self-contained HTML bundle served from public/, kept outside the app/ design system. Rewrite maps the clean /hero-3d-playbook route to the file. Assets are inlined and decoded to blob URLs at runtime. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughNext.js configuration now rewrites ChangesHero 3D Playbook Route
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@next.config.ts`:
- Around line 23-27: Relocate the standalone hero 3D playbook HTML artifact from
the root of public into the appropriate permitted public subdirectory, then
update the rewrite destination in the configuration block for source
"/hero-3d-playbook" to match its new location. Do not amend the guideline;
preserve the existing route behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 83613feb-c26e-4259-9754-92294f962498
📒 Files selected for processing (2)
next.config.tspublic/hero-3d-playbook.html
👮 Files not reviewed due to content moderation or server errors (1)
- public/hero-3d-playbook.html
| // Standalone Product → Hero 3D playbook, served as a raw HTML file from | ||
| // public/hero-3d-playbook.html (kept outside the app/ design system). | ||
| { | ||
| source: "/hero-3d-playbook", | ||
| destination: "/hero-3d-playbook.html", |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
Resolve the public asset placement guideline violation.
This rewrite targets the root-level public/hero-3d-playbook.html, but the repository requires static assets under public/images/, public/videos/, or public/fonts/. Relocate the artifact and update destination, or explicitly amend the guideline for standalone HTML pages before merging.
As per coding guidelines, public/**/* static assets must be placed in public/images/, public/videos/, or public/fonts/.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@next.config.ts` around lines 23 - 27, Relocate the standalone hero 3D
playbook HTML artifact from the root of public into the appropriate permitted
public subdirectory, then update the rewrite destination in the configuration
block for source "/hero-3d-playbook" to match its new location. Do not amend the
guideline; preserve the existing route behavior.
Source: Coding guidelines
What
Adds a standalone Product Photo → Hero 3D playbook page for the Livepeer Agent, served at
/hero-3d-playbook.Approach
public/hero-3d-playbook.html(assets are inlined and decoded toblob:URLs at runtime — no external asset files needed).app/design system intentionally — off-brand, standalone playbook page.next.config.tsmaps the clean/hero-3d-playbookroute to the file.Same pattern as the
/agent-alpha(#84) and/consistency-cheatsheet(#85) pages.Verification
Rendered locally on the dev server at
/hero-3d-playbook— title, heading, stat tiles, and all 4 images load; no console errors.🤖 Generated with Claude Code
Summary by CodeRabbit
/hero-3d-playbookURL.