Fix: ErrorException when user list has been limitated - #694
Merged
Conversation
✅ WordPress Plugin Check Report
📊 ReportAll checks passed! No errors or warnings found. 🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 3.0.2 fixes the "Reference user" dropdown on blogs with many users. Opening the settings page used to raise a PHP notice through trigger_error() whenever the blog had more users than the dropdown lists, which polluted the error log and error-tracking services such as Sentry.
MSLS now detects the truncation from the user query itself by asking for one row more than it displays, and reports the limit as a plain hint below the dropdown instead of as a notice. That also removes the count_users() call, a costly query on large blogs, from the settings page entirely.
These changes fix the issue #693.