Conversation
examples/ was never type-checked anywhere - not by npm run build (only src/ and tests/ are in tsconfig.json's include) and not by CI. This is exactly how the user.login typo in basic-usage.ts (fixed in ae1c0dc) went undetected through the #56 docs/examples audit. Added tsconfig.examples.json, which type-checks examples/ against the real SDK source via a path mapping for the @lujax/github-sdk import (the package isn't installed from npm during local dev, so bare imports need to resolve to src/index.ts instead). Wired a new typecheck:examples script into ci.yml, between build and test. Verified it actually catches the class of bug it's meant to: temporarily reintroduced user.login and confirmed tsc fails with "Property 'login' does not exist on type 'User'", then reverted. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
examples/ was never type-checked anywhere — not by npm run build (only src/ and tests/ are in tsconfig.json's include), and not by CI. This is exactly how the user.login typo in basic-usage.ts (fixed earlier this session) slipped through the #56 docs/examples audit undetected.
Not tied to a tracked GitHub issue — found and closed during the pre-publish audit.