ci: pin libtaurus v0.25.8; drop Windows export workaround - #11
Merged
Conversation
v0.25.8 fixes lutaml/taurus#278 upstream: taurus.h now accepts TAURUS_BUILDING_DLL (what CMake actually defines on taurus_shared) for __declspec(dllexport), so the DLL exports its symbols through the standard mechanism. CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON is no longer needed and was the source of the MSB3073 post-build failure on every Windows job since the workflow was introduced. Also new upstream: taurus_parse_string_flags() with TAURUS_PARSE_DROP_WS_TEXT (whitespace-only text node skipping) -- not yet bound on the Ruby side. Local verification against v0.25.8: 176/176 specs passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/build.yml: pin libtaurus v0.25.0 → v0.25.8 and remove-DCMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ONREADME.adoc: update the CI pin noteWhy drop the export flag
v0.25.8 fixes lutaml/taurus#278:
taurus.hnow acceptsTAURUS_BUILDING_DLL(the define CMake actually sets ontaurus_shared) for__declspec(dllexport). The DLL now exports symbols through the standard mechanism, so the blanketCMAKE_WINDOWS_EXPORT_ALL_SYMBOLSworkaround is obsolete — and it was the source of the recurring MSB3073 post-build failure that kept every Windows job red.Also new upstream (not yet bound)
taurus_parse_string_flags()withTAURUS_PARSE_DROP_WS_TEXT— drops whitespace-only text nodes at parse time (pugixml default / libxml2XML_PARSE_NOBLANKS/ Nokogirinoblanks). Available as follow-up Ruby-side work.Verification
Test plan