Fix init packets clobbering output buffer - #26
Open
madleech wants to merge 3 commits into
Open
Conversation
Contributor
|
@madleech Looks OK to me. But I cannot do any testing as I am away from home. |
plocher
approved these changes
Aug 12, 2026
| _init_buffer = (char *)malloc(_init_length); | ||
| if (_init_buffer == nullptr) | ||
| _init_length = 0; // allocation failed: discard INIT bodies rather than risk a null write | ||
| } |
There was a problem hiding this comment.
Theoretically this will have issues if ever the host's init message ever changes length after being processed once. The truncation keeps memory problems at bay, but the init handler won't ever see those truncated bytes...
Not a practical issue with JMRI today...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue raised in #25. It now stores init packets in their own buffer, but this buffer is only created if an init handler is set up, so memory usage isn't increased for most users.
Breaking change:
process()now no longer returnstrueforINITpackets.Also update the documentation to correct the incorrect documentation of the
processfunction; it returns a boolean, not the packet type.