fix: post finalize account creation - #44
Merged
Merged
Conversation
Dodecahedr0x
changed the title
Dodecahedr0x
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 7, 2026 10:09
2c13858 to
4372e44
Compare
bmuddha
reviewed
Aug 7, 2026
bmuddha
left a comment
bmuddha
left a comment
Collaborator
There was a problem hiding this comment.
We cannot allow such mutation as it bypasses the mutability rules of the runtime and strict magic-root invariants, since we do not control the callback instructions:
- CPI instruction can fund the account from validator authority
- The created account will remain a Placeholder, which might break other assumptions the engine makes about account's lifecycle.
bmuddha
self-requested a review
August 7, 2026 17:19
bmuddha
requested changes
Aug 7, 2026
bmuddha
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 7, 2026 18:58
4372e44 to
e78dddb
Compare
bmuddha
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 7, 2026 21:35
e78dddb to
701f5e0
Compare
Dodecahedr0x
marked this pull request as draft
August 10, 2026 08:37
bmuddha
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 10, 2026 11:05
701f5e0 to
6d0c511
Compare
Dodecahedr0x
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 10, 2026 14:47
6d0c511 to
4372e44
Compare
Dodecahedr0x
changed the base branch from
fix/duplicate-transaction-status
to
replicator
August 10, 2026 14:47
bmuddha
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 10, 2026 15:12
4372e44 to
19fabc2
Compare
Dodecahedr0x
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 10, 2026 17:08
19fabc2 to
3df266d
Compare
bmuddha
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 10, 2026 18:29
3df266d to
910c5bc
Compare
Dodecahedr0x
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 11, 2026 06:08
910c5bc to
d779913
Compare
Dodecahedr0x
force-pushed
the
fix/post-finalize-account-creation
branch
from
August 11, 2026 06:13
d779913 to
6e43d5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #42
Allows mutating uncreated accounts (empty mainnet accounts that will become ephemeral)