MT-23076: document api token expiration - #51
Open
oshchyhol wants to merge 3 commits into
Open
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 7, 2026
Open
4 tasks
oshchyhol
marked this pull request as ready for review
August 21, 2026 11:59
oshchyhol
requested review from
Rabsztok and
VladimirTaytor
and
a lite review from Copilot
August 21, 2026 11:59
There was a problem hiding this comment.
Pull request overview
Updates the Account Management OpenAPI spec to document newly introduced API token expiration behavior, including request parameters, validation rules, and related 422 error cases.
Changes:
- Documented
expires_at(optional, nullable, date-time) forcreateApiToken, including request example and expiry semantics. - Added an optional request body to
resetApiTokento acceptexpires_at, updated cURL sample, and documented 422 behavior for expired tokens. - Documented 422 for permission updates on expired API tokens, and corrected the account-access ApiToken specifier field to
masked_token.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
IgorDobryn
approved these changes
Aug 24, 2026
izikaj
approved these changes
Aug 24, 2026
oshchyhol
force-pushed
the
MT-23076-api-token-expiration
branch
from
August 24, 2026 15:11
4cf1bbe to
e75ba55
Compare
Rabsztok
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MT-23076
API tokens now expire.
createApiTokenaccepts an optionalexpires_at,resetApiTokengains an optional request body with the same param, and permission updates on an expired token are rejected. The spec needs to describe all of it.Changes
createApiToken: new optional nullableexpires_at(ISO 8601 date-time) onCreateApiTokenRequest, plus the request example and the operation description – omitted means the token expires 1 year after creation,nullmeans it never expires, and values must be no more than 5 years aheadresetApiToken: new optional request body carrying the sameexpires_atparam, plus a cURL sample that sends it; the description now says already-expired tokens cannot be reset (422) instead of the old "only tokens with no expiration set can be reset"updatePermissions: documented the 422 response and the reason for it (permissions of an expired API token cannot be updated)ApiTokenspecifier ingetAllUsersInAccount: the field ismasked_token(the token value with all but the last characters masked), nottoken– the API has never returned a full token value thereHow to test
expires_atas an optional nullable date-time with the 1-year default and 5-year cap described, and the request example includes itexpires_atand the cURL sample sending it, and states that expired tokens cannot be resetmasked_tokenon the API token specifier, matching what the endpoint actually returnsPOST /api/api_tokenswith noexpires_at, with a date-time, and withnullall behave as documented, and a past date returns 422Companion PRs
Caveat: merge only after falcon deploys MT-23076 and zap_api_token_expiration is enabled in production – the docs describe the 1-year default, which only applies once the flag is on.