Integrate "Read receipts for desired state" SUP - #209
Open
matlec wants to merge 1 commit into
Open
Conversation
This implements the read receipts SUP (margo/specification-enhancements#77). Signed-off-by: Matthias Lechner <matlec.public@gmail.com>
ajcraig
approved these changes
Aug 25, 2026
phil-abb
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the approved SUP "Read receipts for desired state"
(margo/specification-enhancements#77).
It adds one required field,
adoptedManifestVersion, to theDeploymentStatusManifest. The WFM client reports themanifestVersionof themost recent state manifest it has adopted for each deployment. This lets the
WFM tell, for each deployment, whether the client has picked up the current
desired state. The field is required, so this is a breaking change to the
status report.
Per the SUP, it also makes one identity rule normative on the desired state
idattribute: when the WFM changes the content of an existing deployment,the
idstays the same and the digest changes. A differentididentifies adifferent deployment.
Issues Addressed
Change Type
Please select the relevant options:
Checklist