[SM6.10][NFC] Refactor LinAlg Validations with helpers

[Ashley Coleman (V-FEXrt)]

NFC

Pulls two common boiler plate operations into helper functions then uses them across all the validation rules

Operations are

• Get the LinAlgTargetType for a given matrix without raising a diag if its missing (as those diags are already raised)
• Get the integer value of a Value* that is expected to be an immediate ConstantInt and raise a diag if it isn't

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Refactors DXIL LinAlg validation to reduce repetition by introducing helper utilities for extracting constant operands and for fetching LinAlgTargetType metadata.

Changes:

• Added ValidateConstantIntGetValue(...) to centralize immediate-constant validation and extraction.
• Added GetCheckedLATT(...) to centralize LinAlgTargetTypeMap lookup with std::optional results.
• Updated multiple LinAlg validators to use these helpers instead of repeated dyn_cast/map-lookup sequences.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (2)

lib/DxilValidation/DxilValidation.cpp:1097

• The new helper name GetCheckedLATT is hard to decode for readers unfamiliar with the LATT abbreviation. Consider renaming to a more explicit name (e.g., GetCheckedLinAlgTargetType or GetLinAlgTargetTypeIfPresent) to improve readability/maintainability.

static std::optional<LinAlgTargetType>
GetCheckedLATT(Type *Ty, ValidationContext &ValCtx) {

lib/DxilValidation/DxilValidation.cpp:989

• ValidateConstantIntGetValue both emits a diagnostic (side effect) and returns an optional value, which makes it easy for future call sites to ignore std::nullopt and accidentally continue validation with default/placeholder values. Consider renaming this helper to make the side effect explicit (e.g., GetConstantIntValueOrEmitError) and/or documenting the expected usage pattern (treat nullopt as 'validation already failed for this operand').

static std::optional<uint64_t>
ValidateConstantIntGetValue(CallInst *CI, Value *V, ValidationContext &ValCtx,
                            StringRef ValueName, StringRef OpName) {
  if (!isa<ConstantInt>(V)) {
    ValCtx.EmitInstrFormatError(CI, ValidationRule::InstrOpConst,
                                {ValueName, OpName});
    return std::nullopt;
  }

  return cast<ConstantInt>(V)->getLimitedValue();
}