[NFC] Pin the LinAlg execution tests to HLSL 2021 - #8801
Merged
Jack Elliott (JoeCitizen) merged 1 commit intoAug 19, 2026
Merged
Conversation
The LinAlg execution tests passed -HV 202x when compiling every shader. 202x is an in-progress language version: DXC does not list it as a valid argument, and rejecting an unknown version reports "Valid versions: 2015, 2016, 2017, 2018, and 2021". Conformance tests should not be pinned to a language version that is still changing, so this pins them to 2021, the newest released version and the one an unset -HV already selects (LangStd::vLatest is v2021). The switch is inert for these tests. Their shaders take every numeric value from bound buffers through macro-typed elements and contain no floating point literals, so the conforming-literal rules that distinguish 202x from 2021 cannot apply. Compiling the twelve LinAlg builtin codegen shaders under both versions produces byte identical DXIL for eleven of them; the twelfth differs only because it assigns an unsuffixed literal to a double, and it does not request 202x in the first place. The full HLSLExec LinAlg suite is unchanged per test against main on a current D3D12 runtime: 59 total, 58 passed, 0 failed, 1 skipped, with no D3D12 errors and no per-test differences. Assisted-by: GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 83725f5d-8e98-4c1d-91ee-ad47629e007b
Contributor
There was a problem hiding this comment.
Pull request overview
Pins LinAlg execution-test shader compilation to stable HLSL 2021 instead of experimental 202x.
Changes:
- Replaces
-HV 202xwith-HV 2021across all LinAlg compiler-argument paths. - Preserves existing 16-bit type flags and test behavior.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Damyan Pepper (damyanp)
approved these changes
Aug 18, 2026
Ashley Coleman (V-FEXrt)
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LinAlg execution tests passed
-HV 202xwhen compiling every shader. This isn't a requirement so just use 2021