FIX preserve active GCG annealing loss - #2488
Open
Roman Lutz (romanlutz) wants to merge 3 commits into
Open
Conversation
Restore hidden bibliography parity for the SATA citation and ensure annealing compares each candidate with the active suffix after a rejection. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GCG simulated annealing compared a new candidate with the previously evaluated loss, even when that candidate had been rejected. This could accept a suffix that is worse than the active suffix simply because it improves on an earlier rejected candidate.
Compare candidates with
OptimizationRunState.loss, which always describes the active control, and retaincandidate_lossonly as the latest evaluated loss. A deterministic regression test covers consecutive rejected candidates. This also restores hidden bibliography parity by adding the existing SATA citation key todoc/bibliography.md.Tests and Documentation