I updated the version dropdown logic in TypeScript-Website/packages/p…#3488
Closed
samay-hash wants to merge 1 commit into
Closed
I updated the version dropdown logic in TypeScript-Website/packages/p…#3488samay-hash wants to merge 1 commit into
samay-hash wants to merge 1 commit into
Conversation
…layground/src/index.ts so that development builds now correctly show their release dates.
Author
|
agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I finished adding release dates to each TypeScript release in the Playground.
What I changed,
I updated the version dropdown logic in TypeScript-Website/packages/playground/src/index.ts so that development builds now correctly show their release dates.
Instead of trying to load dates from JSON files, I added logic that:
Detects version strings with the pattern -dev.YYYYMMDD
Extracts the date from the version
Displays it in the format:
(YYYY-MM-DD)
the issues was The existing code attempted to fetch release dates from releases.json and pre-releases.json, and those files only contain version numbers but Development builds already include the date inside the version string but that information wasn’t being parsed or shown in the UI.