Shrink relationComplexityError test size - #62754
Merged
Jake Bailey (jakebailey) merged 1 commit intoNov 13, 2025
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Ryan Cavanaugh (RyanCavanaugh) and
Copilot
November 13, 2025 21:26
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Nov 13, 2025
Copilot started reviewing on behalf of
Jake Bailey (jakebailey)
November 13, 2025 21:27
View session
Jake Bailey (jakebailey)
enabled auto-merge (squash)
November 13, 2025 21:27
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the size of the relationComplexityError compiler test to prevent timeouts on slower build machines. By reducing the Digits type from 10 literal types ('0'-'9') to 8 literal types ('0'-'7'), the number of type combinations drops from 10,000 to 4,096, significantly improving test performance while still reproducing the relation complexity error from issue #55630.
Key Changes
- Reduced
Digitstype from 10 literals to 8 literals, decreasing type combinations from 10^4 to 8^4 - Updated all baseline files to reflect the reduced Type Count (from 25,000 to 10,000) and adjusted symbol positions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/cases/compiler/relationComplexityError.ts | Removed '8' and '9' from the Digits type to reduce test complexity |
| tests/baselines/reference/relationComplexityError.types | Updated type count from 25,000 to 10,000 and refreshed type baselines |
| tests/baselines/reference/relationComplexityError.symbols | Updated symbol declaration positions to reflect shorter Digits type definition |
| tests/baselines/reference/relationComplexityError.errors.txt | Updated error baseline to reflect the reduced Digits type |
Jake Bailey (jakebailey)
merged commit Nov 13, 2025
ea48ded
into
microsoft:main
36 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting tired of this test timing out on slower builders.