Fix TypeScript package major-minor version - #63940
Merged
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch)
and
a balanced review from Copilot
August 21, 2026 04:49
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the TypeScript package’s major-minor version to 7.1.
Changes:
- Corrects runtime and declaration version exports.
- Adds a compiler-version consistency test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/typescript/test/version.test.ts |
Tests the runtime version export. |
packages/typescript/lib/version.d.cts |
Updates the declared version to 7.1. |
packages/typescript/lib/version.cjs |
Updates the runtime version to 7.1. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Andrew Branch (andrewbranch)
approved these changes
Aug 21, 2026
Andrew Branch (andrewbranch)
left a comment
Andrew Branch (andrewbranch)
left a comment
Member
There was a problem hiding this comment.
Yeah, the literal in the declaration file is why I didn't just import it from package.json, but we could generate it. This is fine though.
Member
Author
|
Updated to also test the other version, just to be safe for now. |
Andrew Branch (andrewbranch)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hardcoded version was wrong.
Perhaps instead of being hardcoded, we should derive it from something, but it has to be a literal in the
d.ts, so, not bothering.(Needed because dtslint needs this info for local TS versions)