Skip to content

fix(64058): fix reparse jsdoc @extends type arguments for call expressions - #64072

Open
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/64058
Open

fix(64058): fix reparse jsdoc @extends type arguments for call expressions#64072
Oleksandr Tarasiuk (a-tarasyuk) wants to merge 1 commit into
microsoft:mainfrom
a-tarasyuk:fix/64058

Conversation

@a-tarasyuk

Copy link
Copy Markdown
Contributor

Fixes #64058

Copilot AI balanced review requested due to automatic review settings August 28, 2026 08:01
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Aug 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes JSDoc @extends type arguments for call-expression heritage clauses.

Changes:

  • Copies JSDoc type arguments onto the parsed heritage node.
  • Adds parser and compiler regression coverage.
  • Removes the previous property-access matching helper.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tsc/internal/parser/reparser.go Reparses @extends type arguments.
tsc/internal/ast/utilities.go Removes the old name-matching helper.
tsc/internal/parser/parser_test.go Tests reparsed AST linkage.
tsc/testdata/tests/cases/conformance/jsdoc/extendsTag7.ts Adds the compiler regression case.
tsc/testdata/baselines/reference/conformance/extendsTag7.types Records inferred types.
tsc/testdata/baselines/reference/conformance/extendsTag7.symbols Records resolved symbols.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread tsc/internal/parser/reparser.go Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Not started

Development

Successfully merging this pull request may close these issues.

TS7: @extends is ignored when the heritage is a call expression (Base.extend())

2 participants