Make tsconfig move lifetime test deterministic - #64081
Merged
Jake Bailey (jakebailey) merged 1 commit intoAug 28, 2026
Merged
Conversation
Jake Bailey (jakebailey)
requested review from
Andrew Branch (andrewbranch)
and
a balanced review from Copilot
August 28, 2026 18:24
Contributor
There was a problem hiding this comment.
Pull request overview
Makes the project-lifetime test deterministic by explicitly waiting for background updates and validating deferred inferred-project cleanup.
Changes:
- Adds a second source file to trigger cleanup.
- Verifies project routing before and after deferred cleanup.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Andrew Branch (andrewbranch)
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is racy:
https://github.com/microsoft/TypeScript/actions/runs/33124839650/job/98700352742
This is because we defer inferred cleanup until later, so we could observe it both ways. Make the test happier with this situation.