Fix SymbolFlags.All value by parsing operator precedence when generating TS enums from Go enums - #64083
Merged
Andrew Branch (andrewbranch) merged 5 commits intoAug 28, 2026
Conversation
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
August 28, 2026 20:32
View session
Jake Bailey (jakebailey)
approved these changes
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Go-to-TypeScript enum generation by preserving Go operator precedence and validating generated values against Go.
Changes:
- Adds precedence-aware numeric expression translation.
- Validates generated enum values using Go-evaluated ground truth.
- Corrects and tests
SymbolFlags.All.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
Herebyfile.mjs |
Adds expression parsing and value validation. |
tsc/internal/api/enum_values_generated.go |
Provides generated Go enum values. |
packages/typescript/src/enums/symbolFlags.enum.ts |
Parenthesizes the Go shift expression. |
packages/typescript/src/enums/symbolFlags.ts |
Corrects the runtime value. |
packages/typescript/test/sync/api.test.ts |
Adds synchronous regression coverage. |
packages/typescript/test/async/api.test.ts |
Adds asynchronous regression coverage. |
Files not reviewed (1)
- tsc/internal/api/enum_values_generated.go: Generated file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Andrew Branch (andrewbranch)
enabled auto-merge
August 28, 2026 20:35
Jake Bailey (jakebailey)
approved these changes
Aug 28, 2026
Andrew Branch (andrewbranch)
deleted the
fix-symbol-all-operator-precedence
branch
August 28, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is #63907 with an additional commit